8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java fails with unexpected exit code: 112 #20397

sspitsyn · 2024-07-30T23:13:23Z

The test has been fixed to:

add a guard against JVMTI_ERROR_WRONG_PHASE
replace exit(err) with abort() in the check_jvmti_error()

The JVMTI VMDeath event is enabled and a RawMonitor is introduced to serialize ClassPrepare and VMDeath events, and so, to prevent JVMTI_ERROR_WRONG_PHASE in the ClassPrepare events.

Testing:

run the test AllowedFunctions.java locally
TBD: submit a mach5 run for fixed test

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java fails with unexpected exit code: 112 (Bug - P4)

Reviewers

Chris Plummer (@plummercj - Reviewer)
Alex Menkov (@alexmenkov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20397/head:pull/20397
$ git checkout pull/20397

Update a local copy of the PR:
$ git checkout pull/20397
$ git pull https://git.openjdk.org/jdk.git pull/20397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20397

View PR using the GUI difftool:
$ git pr show -t 20397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20397.diff

Webrev

Link to Webrev Comment

…tions.java fails with unexpected exit code: 112

bridgekeeper · 2024-07-30T23:13:48Z

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-07-30T23:14:55Z

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java fails with unexpected exit code: 112

Reviewed-by: cjplummer, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

7146dae: 8337783: Use THROW_NULL instead of THROW_0 in pointer contexts in misc runtime code
431d4f7: 8337785: Fix simple -Wzero-as-null-pointer-constant warnings in x86 code
e2c07d5: 8337299: vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java failure goes undetected
08f697f: 8337819: Update GHA JDKs to 22.0.2
42652b2: 8337787: Fix -Wzero-as-null-pointer-constant warnings when JVMTI feature is disabled
807186f: 8337784: Fix simple -Wzero-as-null-pointer-constant warnings in linux/posix code
e68df52: 8337054: JDK 23 RDP2 L10n resource files update
9856216: 8336928: GHA: Bundle artifacts removal broken
219e1eb: 8337712: Wrong javadoc in java.util.Date#toString(): "61" and right parenthesis
97afbd9: 8336410: runtime/NMT/TotalMallocMmapDiffTest.java Total malloc diff is incorrect. Expected malloc diff range
... and 43 more: https://git.openjdk.org/jdk/compare/6c3ba5a6c47d29908ddaf58582ee8d26bb8779f9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-07-30T23:15:22Z

@sspitsyn The following label will be automatically applied to this pull request:

serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-07-30T23:17:56Z

Webrevs

sspitsyn · 2024-07-30T23:19:16Z

Converting the native agent to C++ would simplify the test and allow to use utility functions from the jvmti_common.hpp.
But I wanted to make the WRONG_PHASE related fix to be clear for reviewers.
So, this conversion can be done as a separate step or as a part of a separate effort covered by an enhancement.

plummercj · 2024-08-01T22:00:52Z

test/hotspot/jtreg/serviceability/jvmti/StartPhase/AllowedFunctions/libAllowedFunctions.c

+    // Block VMDeath event and other ClassPrepare events while this callback is executed.
+    // Sync with VMDeath event guards agains JVMTI_ERROR WRONG_PHASE.
+    err = (*jvmti)->RawMonitorEnter(jvmti, event_mon);


I don't see how this fixes the problem. You can be exiting VMDeath when this monitor is entered. This does not block the get_thread_local() call below, which is what leads to the WRONG_PHASE. I think using a raw monitor is the right approach, but I was expecting to see VMDeath set a flag after grabbing the monitor that indicated VMDeath had been called. Then ClassPrepare should check this flag after grabbing the monitor and ignore the event if it is set.

Thank you for the comment.
Fixed the get_thread_local() issue and corrected phase check.
New flag is not really needed as the phase == JVMTI_PHASE_DEAD can play its role.
Please, let me know if you are not okay with that.

plummercj · 2024-08-01T22:01:43Z

test/hotspot/jtreg/serviceability/jvmti/StartPhase/AllowedFunctions/libAllowedFunctions.c

+    jvmtiError err;
+
+    // Block VMDeath event and other ClassPrepare events while this callback is executed.
+    // Sync with VMDeath event guards agains JVMTI_ERROR WRONG_PHASE.


Suggested change

// Sync with VMDeath event guards agains JVMTI_ERROR WRONG_PHASE.

// Sync with VMDeath event guards agains JVMTI_ERROR_WRONG_PHASE.

Fixed now, thanks!

plummercj · 2024-08-02T23:05:36Z

test/hotspot/jtreg/serviceability/jvmti/StartPhase/AllowedFunctions/libAllowedFunctions.c


    get_phase(jvmti, &phase);
    if (phase != JVMTI_PHASE_START && phase != JVMTI_PHASE_LIVE) {
-        printf("  ## Error: unexpected phase: %d, expected: %d or %d\n",
-               phase, JVMTI_PHASE_START, JVMTI_PHASE_LIVE);
+        if (phase != JVMTI_PHASE_DEAD) {


After this check is made, what prevents JVMTI from moving to the JVMTI_PHASE_DEAD before the get_cur_thread() call below? I'm not sure if the phase is changed to JVMTI_PHASE_DEAD before or after calling VMDeath, but it seems in either case you can end up with the phase changing after making this check. There is nothing that stops the phase from changing while holding the raw monitor.

Thanks, Chris.
The JvmtiExport::post_vm_death() posts the VMDeath before changing the phase to JVMTI_PHASE_DEAD.
The VMDeath callback is blocked on the RawMonitor while it is grabbed by the ClassPrepare event callback.
But you are right, there is a sync gap in JvmtiExport::post_vm_death() between the VMDeath callback execution and phase changing. So, I'll go with your suggestion and introduce a flag.

Added is_vm_dead flag.

plummercj · 2024-08-03T04:15:01Z

test/hotspot/jtreg/serviceability/jvmti/StartPhase/AllowedFunctions/libAllowedFunctions.c


+    if (is_vm_dead == JNI_TRUE) {


Suggested change

if (is_vm_dead == JNI_TRUE) {

if (is_vm_dead) {

Thanks, updated now.

plummercj

Looks good.

sspitsyn · 2024-08-05T21:55:39Z

Thank you for review, Chris!

sspitsyn · 2024-08-05T23:27:59Z

Thank you for review, Alex!

sspitsyn · 2024-08-05T23:28:37Z

/integrate

openjdk · 2024-08-05T23:29:18Z

Going to push as commit 965d6b9.
Since your change was applied there have been 53 commits pushed to the master branch:

7146dae: 8337783: Use THROW_NULL instead of THROW_0 in pointer contexts in misc runtime code
431d4f7: 8337785: Fix simple -Wzero-as-null-pointer-constant warnings in x86 code
e2c07d5: 8337299: vmTestbase/nsk/jdb/stop_at/stop_at002/stop_at002.java failure goes undetected
08f697f: 8337819: Update GHA JDKs to 22.0.2
42652b2: 8337787: Fix -Wzero-as-null-pointer-constant warnings when JVMTI feature is disabled
807186f: 8337784: Fix simple -Wzero-as-null-pointer-constant warnings in linux/posix code
e68df52: 8337054: JDK 23 RDP2 L10n resource files update
9856216: 8336928: GHA: Bundle artifacts removal broken
219e1eb: 8337712: Wrong javadoc in java.util.Date#toString(): "61" and right parenthesis
97afbd9: 8336410: runtime/NMT/TotalMallocMmapDiffTest.java Total malloc diff is incorrect. Expected malloc diff range
... and 43 more: https://git.openjdk.org/jdk/compare/6c3ba5a6c47d29908ddaf58582ee8d26bb8779f9...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-08-05T23:29:24Z

@sspitsyn Pushed as commit 965d6b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunc…

f497266

…tions.java fails with unexpected exit code: 112

openjdk bot added the rfr Pull request is ready for review label Jul 30, 2024

openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 30, 2024

plummercj reviewed Aug 1, 2024

View reviewed changes

sspitsyn added 2 commits August 2, 2024 20:28

corrections in test ClassPrepare event handler

fd869ea

fix typo in a comment

1671dab

plummercj reviewed Aug 2, 2024

View reviewed changes

sspitsyn added 2 commits August 3, 2024 03:13

introduced is_vm_dead flag to prevent WRONG_PHASE error

4cf09f7

tweeked comment in ClassPrepare event callback

2a0c56b

plummercj reviewed Aug 3, 2024

View reviewed changes

minor simplified tweak

c2b11c2

plummercj approved these changes Aug 5, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 5, 2024

alexmenkov approved these changes Aug 5, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Aug 5, 2024

openjdk bot closed this Aug 5, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 5, 2024

sspitsyn deleted the b37 branch August 14, 2024 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java fails with unexpected exit code: 112 #20397

8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java fails with unexpected exit code: 112 #20397

sspitsyn commented Jul 30, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jul 30, 2024

openjdk bot commented Jul 30, 2024 •

edited

Loading

openjdk bot commented Jul 30, 2024

mlbridge bot commented Jul 30, 2024 •

edited

Loading

sspitsyn commented Jul 30, 2024

plummercj Aug 1, 2024

sspitsyn Aug 2, 2024

plummercj Aug 1, 2024

sspitsyn Aug 2, 2024

plummercj Aug 2, 2024

sspitsyn Aug 3, 2024

sspitsyn Aug 3, 2024

plummercj Aug 3, 2024

sspitsyn Aug 3, 2024

plummercj left a comment

sspitsyn commented Aug 5, 2024

sspitsyn commented Aug 5, 2024

sspitsyn commented Aug 5, 2024

openjdk bot commented Aug 5, 2024

openjdk bot commented Aug 5, 2024

	// Sync with VMDeath event guards agains JVMTI_ERROR WRONG_PHASE.
	// Sync with VMDeath event guards agains JVMTI_ERROR_WRONG_PHASE.

8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java fails with unexpected exit code: 112 #20397

8335836: serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java fails with unexpected exit code: 112 #20397

Conversation

sspitsyn commented Jul 30, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jul 30, 2024

openjdk bot commented Jul 30, 2024 • edited Loading

openjdk bot commented Jul 30, 2024

mlbridge bot commented Jul 30, 2024 • edited Loading

Webrevs

sspitsyn commented Jul 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

plummercj left a comment

Choose a reason for hiding this comment

sspitsyn commented Aug 5, 2024

sspitsyn commented Aug 5, 2024

sspitsyn commented Aug 5, 2024

openjdk bot commented Aug 5, 2024

openjdk bot commented Aug 5, 2024

sspitsyn commented Jul 30, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jul 30, 2024 •

edited

Loading

mlbridge bot commented Jul 30, 2024 •

edited

Loading