Skip to content

Conversation

@kimbarrett
Copy link

@kimbarrett kimbarrett commented Jul 31, 2024

Please review this trivial change that removes some uses of literal 0 as a
null pointer constant in jvmci code.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337523: Fix -Wzero-as-null-pointer-constant warnings in jvmci code (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20399/head:pull/20399
$ git checkout pull/20399

Update a local copy of the PR:
$ git checkout pull/20399
$ git pull https://git.openjdk.org/jdk.git pull/20399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20399

View PR using the GUI difftool:
$ git pr show -t 20399

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20399.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2024

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337523: Fix -Wzero-as-null-pointer-constant warnings in jvmci code

Reviewed-by: chagedorn, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • de0b504: 8336912: G1: Undefined behavior for G1ConfidencePercent=0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 31, 2024
@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@kimbarrett The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jul 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2024

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 31, 2024
@kimbarrett
Copy link
Author

Thanks for reviews @chhagedorn and @shipilev

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

Going to push as commit 61386c1.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 07dd725: 8337418: Fix -Wzero-as-null-pointer-constant warnings in prims code
  • c73b3cb: 8336635: Add IR test for Reference.refersTo intrinsic
  • 9b428dd: 8336242: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/SimpleDebugInfoTest.java failed assert(oopDesc::is_oop_or_null(val)) failed: bad oop found (again)
  • de0b504: 8336912: G1: Undefined behavior for G1ConfidencePercent=0

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 31, 2024
@openjdk openjdk bot closed this Jul 31, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jul 31, 2024
@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@kimbarrett Pushed as commit 61386c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 31, 2024
@kimbarrett kimbarrett deleted the simple-jvmci branch July 31, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants