Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac #204

Closed
wants to merge 4 commits into from

Conversation

trebari
Copy link
Member

@trebari trebari commented Sep 16, 2020

The test test/jdk/javax/swing/JPopupMenu/4966112/bug4966112.java fails for Mac OS X
with the error message Popup was not shown on FileChooser.

Popup doesn't appear for JFileChooser in MAC OS X platform so
skipping this test for Mac OS X.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/204/head:pull/204
$ git checkout pull/204

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back trebari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@trebari The following label will be automatically applied to this pull request: swing.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

@mrserb
Copy link
Member

mrserb commented Sep 16, 2020

Why the popup does not show for this component? Why the filechooser on the mac is so specific?

@trebari
Copy link
Member Author

trebari commented Sep 17, 2020

The test creates a JFileChooser and a popup and then click on the middle of the JFileChooser.

In case of MAC OS X the context popup doesn't work when clicking on the area where files are(the area with the scroll bar) in the filechooser.

But context popup works when clicking on the other areas of the JFilechooser like
1. Upper area where the directory link is given
2. Below area where file format comboBox is there and the close and open buttons are there.
3. Context popup doesn't work when clicking on the buttons(close, open) and the ComboBoxes

so the test fails because the context popup doesn't work when clicking the middle area of JFileChooser in mac os x.

There are two ways to make the test pass, one to omit the mac os x platform for JFilechooser part which i did in this PR.
second to click on the other areas of the JFileChooser where the context popup work for mac os x.

@mrserb
Copy link
Member

mrserb commented Sep 19, 2020

So the popup actually works in that dialog, we just need to test it in a different place?

@trebari
Copy link
Member Author

trebari commented Sep 21, 2020

So the popup actually works in that dialog, we just need to test it in a different place?

Yes.

@mrserb
Copy link
Member

mrserb commented Sep 23, 2020

So the popup actually works in that dialog, we just need to test it in a different place?
Yes.

Then it looks like in Aqua, we can test that "different place".

@trebari
Copy link
Member Author

trebari commented Sep 24, 2020

Testing context popup for Filechooser on AquaLAF at the different place where the context popup works.
Internal test run link is in JBS, All Green.

@openjdk
Copy link

openjdk bot commented Sep 26, 2020

@trebari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for more details.

After integration, the commit message for the final commit will be:

7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

Reviewed-by: serb, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 170 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @jayathirthrao) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 26, 2020
@trebari
Copy link
Member Author

trebari commented Sep 29, 2020

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 29, 2020
@openjdk
Copy link

openjdk bot commented Sep 29, 2020

@trebari
Your change (at version f7782dc) is now ready to be sponsored by a Committer.

@jayathirthrao
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Sep 30, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Sep 30, 2020
@openjdk
Copy link

openjdk bot commented Sep 30, 2020

@jayathirthrao @trebari Since your change was applied there have been 182 commits pushed to the master branch:

  • 1eca634: 8252000: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdb
  • a55cde4: 8252002: remove usage of PropertyResolvingWrapper in vmTestbase/nsk/jdwp
  • ffc97ba: 8253543: sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java failed with "AssertionError: All pixels are not black"
  • 5310d85: 8252937: Correct "no comment" warnings from javadoc in java.math package
  • 8df3e72: 8218685: jlink --list-plugins needs to be readable and tidy
  • 2fe0a5d: 8253476: TestUseContainerSupport.java fails on some Linux kernels w/o swap limit capabilities
  • fb20690: 8253637: Update EC removal
  • b1ce6bd: 8253548: jvmFlagAccess.cpp: clang 9.0.0 format specifier error
  • ff6843c: 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high
  • d5be829: 8253770: Test tools/javac/parser/JavacParserTest.java fails on Windows after JDK-8253584
  • ... and 172 more: https://git.openjdk.java.net/jdk/compare/efe3540d8f3156b337133ad12272834f6ded2203...master

Your commit was automatically rebased without conflicts.

Pushed as commit 4d9f207.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
4 participants