Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8249867: xml declaration is not followed by a newline #2041

Closed
wants to merge 5 commits into from

Conversation

JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Jan 12, 2021

Please review a patch to add an explicit control over whether a newline should be added after the XML header. This is done by adding a DOM LSSerializer property "jdk-is-standalone" and System property "jdk.xml.isStandalone".

This change addresses an incompatibility introduced during 7u4 as an update to Xalan 2.7.1.

/issue add 8249867
/csr


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8249867: xml declaration is not followed by a newline

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2041/head:pull/2041
$ git checkout pull/2041

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2021

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@JoeWang-Java This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Jan 12, 2021
@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@JoeWang-Java this pull request will not be integrated until the CSR request JDK-8259352 for issue JDK-8249867 has been approved.

@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jan 12, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2021

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

When setting the fDOMConfigProperties is the difference between simple values of "yes" and "no" and the values of DOMConstants.DOM3_EXPLICIT_TRUE/FALSE significant?

@JoeWang-Java
Copy link
Member Author

JoeWang-Java commented Jan 12, 2021

The DOMConfigProperties differentiate "Explicit" values from the default ones. DOM3_EXPLICIT_TRUE/FALSE has a string form: explicit:yes/explicit:no, while the default ones default:yes/default:no. In some cases (for some parameters), default values are handled differently from the explicit ones.

In this case, it's not significant for the new property as to how it was processed. I merely followed the existing practice and mechanism to align with the existing parameters.

naotoj
naotoj approved these changes Jan 13, 2021
@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Jan 27, 2021
@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8249867: xml declaration is not followed by a newline

Reviewed-by: rriggs, naoto, lancea, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 350 new commits pushed to the master branch:

  • 739bbd0: 8260566: Pattern type X is a subtype of expression type Y message is incorrect
  • b2e582a: 8259905: Compiler treats 'sealed' keyword as 'var' keyword
  • 6415d3b: 8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2)
  • b7b391b: 8260625: Rename MetaspaceExpand_lock
  • 22bfa5b: 8255837: Shenandoah: Remove ShenandoahConcurrentRoots class
  • 53f1b93: 8260518: Change default -mmacosx-version-min to 10.12
  • 24a2621: 8260592: jpackage tests fail when Desktop is not supported
  • d2b0ea1: 8260282: Add option to compress heap dumps created by -XX:+HeapDumpOnOutOfMemoryError
  • a5fb517: 8259404: Shenandoah: Fix time tracking in parallel_cleaning
  • 0675473: 8252409: JShell: Intersection types cause NoSuchFieldError
  • ... and 340 more: https://git.openjdk.java.net/jdk/compare/56a354eb554a38e7853aba927302244e8cc07f6c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2021
src/java.xml/share/classes/module-info.java Outdated Show resolved Hide resolved
src/java.xml/share/classes/module-info.java Outdated Show resolved Hide resolved
src/java.xml/share/classes/module-info.java Outdated Show resolved Hide resolved
src/java.xml/share/classes/module-info.java Outdated Show resolved Hide resolved
src/java.xml/share/classes/module-info.java Outdated Show resolved Hide resolved
Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Hi Joe,

The latest changes look fine

naotoj
naotoj approved these changes Jan 29, 2021
dfuch
dfuch approved these changes Jan 29, 2021
Copy link
Member

@dfuch dfuch left a comment

I have just two cosmetic comments. Otherwise LGTM!

src/java.xml/share/classes/module-info.java Outdated Show resolved Hide resolved
src/java.xml/share/classes/module-info.java Show resolved Hide resolved
dfuch
dfuch approved these changes Jan 29, 2021
@JoeWang-Java
Copy link
Member Author

JoeWang-Java commented Jan 30, 2021

/integrate

@openjdk openjdk bot closed this Jan 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2021
@openjdk
Copy link

openjdk bot commented Jan 30, 2021

@JoeWang-Java Since your change was applied there have been 353 commits pushed to the master branch:

  • fb46c91: 8260674: ProblemList jdk/incubator/vector/VectorHash.java in Xcomp configs
  • 71bfe96: 8217633: Configurable extensions with system properties
  • f5ca838: 8065773: JDI: UOE is not thrown, when redefineClasses changes a class modifier
  • 739bbd0: 8260566: Pattern type X is a subtype of expression type Y message is incorrect
  • b2e582a: 8259905: Compiler treats 'sealed' keyword as 'var' keyword
  • 6415d3b: 8259584: SuperWord::fix_commutative_inputs checks in_bb(fin1) instead of in_bb(fin2)
  • b7b391b: 8260625: Rename MetaspaceExpand_lock
  • 22bfa5b: 8255837: Shenandoah: Remove ShenandoahConcurrentRoots class
  • 53f1b93: 8260518: Change default -mmacosx-version-min to 10.12
  • 24a2621: 8260592: jpackage tests fail when Desktop is not supported
  • ... and 343 more: https://git.openjdk.java.net/jdk/compare/56a354eb554a38e7853aba927302244e8cc07f6c...master

Your commit was automatically rebased without conflicts.

Pushed as commit 69ee314.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8249867 branch Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
5 participants