8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows

[SoniaZaldana]

Hi all,

This PR addresses 8337667 .

The Compiler.perfmap test case is failing on mac and windows as it is only enabled in linux. I am removing this test case and noting that this use case is already tested in test/hotspot/jtreg/serviceability/dcmd/compiler/PerfMapTest.java which is linux specific.

Thanks,
Sonia

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows (Bug - P2) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20421/head:pull/20421
$ git checkout pull/20421

Update a local copy of the PR:
$ git checkout pull/20421
$ git pull https://git.openjdk.org/jdk.git pull/20421/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20421

View PR using the GUI difftool:
$ git pr show -t 20421

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20421.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@SoniaZaldana This change is no longer ready for integration - check the PR body for details.

[openjdk]

@SoniaZaldana The following labels will be automatically applied to this pull request:

• core-libs
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a825c6ac)

[AlanBateman]

/label remove core-libs

[openjdk]

@AlanBateman
The core-libs label was successfully removed.

[kevinjwalls]

Thanks, looks good.

[tstuefe]

+1

[plummercj]

@SoniaZaldana We are seeing a lot of noise in our CI due to this issue. Can you please integrate the fix soon? Thanks!

[dholmes-ora]

FWIW this could have been guarded by a platform check.

[plummercj]

System.dump_map also is only supported on linux.

[dholmes-ora]

If @SoniaZaldana is not around to integrate this perhaps one of the reviewers could create a new PR.

[plummercj]

I'm working on it. I'll also add the Linux check.

[tstuefe]

I'm working on it. I'll also add the Linux check.

Please do. I think she is on vacation. Sorry for the delay!

[plummercj]

Please review #20480. This PR should be closed without integrating.

[openjdk]

@SoniaZaldana this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8337667
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[SoniaZaldana]

Hi all, apologies I was away for a few days. Thanks for following up @plummercj.