6426678: (spec) File.createTempFile(prefix, suffix, dir) needs clarification for illegal symbols in suffix

[bplb]

Add some verbiage indicating that an IOException will be thrown if a file with a name generated from the supplied prefix and suffix according to the described algorithm cannot be generated by the underlying system, whether that be due to the presence of one of more characters not supported by the underlying system or for some other reason.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8338009 to be approved

Issues

• JDK-6426678: (spec) File.createTempFile(prefix, suffix, dir) needs clarification for illegal symbols in suffix (Bug - P4)
• JDK-8338009: (spec) File.createTempFile(prefix, suffix, dir) needs clarification for illegal symbols in suffix (CSR)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20435/head:pull/20435
$ git checkout pull/20435

Update a local copy of the PR:
$ git checkout pull/20435
$ git pull https://git.openjdk.org/jdk.git pull/20435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20435

View PR using the GUI difftool:
$ git pr show -t 20435

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20435.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6426678: (spec) File.createTempFile(prefix, suffix, dir) needs clarification for illegal symbols in suffix

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 297 new commits pushed to the master branch:

• a528c4b: 8339156: Use more fine-granular clang unused warnings
• 2fb8305: 8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java
• 3a352b8: 8339191: JFR: Bulk read support for ChunkInputStream
• 92c4704: 8339166: java/lang/String/concat/HiddenClassUnloading.java fails on AIX and Linux ppc64le after JDK-8336856
• 2abe2ff: 8339235: Fix indentation in build system
• bb28b0d: 8338404: Cross-compilation to different endianness fails after JDK-8318913
• b872718: 8338301: Error recovery and reporting should be improved for erroneous implicitly declared classes
• b9e65f9: 8337662: Improve os::print_hex_dump for printing Instructions sections
• f927c12: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java
• 4675913: 8339237: RISC-V: Builds fail after JDK-8339120
• ... and 287 more: https://git.openjdk.org/jdk/compare/f1fa64b6b67f2eef916b8d92eb522ccb19035e12...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (64440ec8)
• 00: Full (79e00800)

[openjdk]

@bplb usage: /csr [needed|unneeded], requires that the issue the pull request refers to links to an approved CSR request.

[bplb]

/csr

[openjdk]

@bplb has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@bplb please create a CSR request for issue JDK-6426678 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[bplb]

/integrate

[openjdk]

Going to push as commit fef1ef7.
Since your change was applied there have been 297 commits pushed to the master branch:

• a528c4b: 8339156: Use more fine-granular clang unused warnings
• 2fb8305: 8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java
• 3a352b8: 8339191: JFR: Bulk read support for ChunkInputStream
• 92c4704: 8339166: java/lang/String/concat/HiddenClassUnloading.java fails on AIX and Linux ppc64le after JDK-8336856
• 2abe2ff: 8339235: Fix indentation in build system
• bb28b0d: 8338404: Cross-compilation to different endianness fails after JDK-8318913
• b872718: 8338301: Error recovery and reporting should be improved for erroneous implicitly declared classes
• b9e65f9: 8337662: Improve os::print_hex_dump for printing Instructions sections
• f927c12: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java
• 4675913: 8339237: RISC-V: Builds fail after JDK-8339120
• ... and 287 more: https://git.openjdk.org/jdk/compare/f1fa64b6b67f2eef916b8d92eb522ccb19035e12...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit fef1ef7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.