JDK-8259569: gtest os.dll_address_to_function_and_library_name_vm fails

[tstuefe]

May I have reviews please for this small and trivial change.

With JDK-8258606 (https://bugs.openjdk.java.net/browse/JDK-8258606), I added a new function to print a function pointer, as well as gtests. Turns out the gtests are too fragile, e.g. depend on the existence of the demangle library on AIX - so I remove some parts of them.

Thanks, Thomas

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259569: gtest os.dll_address_to_function_and_library_name_vm fails

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2044/head:pull/2044
$ git checkout pull/2044

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (159869b)
• 00: Full (b03dcb1)

[dcubed-ojdk]

Is your repo out of date? I don't see a reversal of the change that
I integrated yesterday to disable the subtest:

JDK-8259586 ProblemList dll_address_to_function_and_library_name
https://bugs.openjdk.java.net/browse/JDK-8259586

[tstuefe]

Is your repo out of date? I don't see a reversal of the change that
I integrated yesterday to disable the subtest:

JDK-8259586 ProblemList dll_address_to_function_and_library_name
https://bugs.openjdk.java.net/browse/JDK-8259586

Hi Dan, yes, I missed that. I re-enabled the test.

Thanks, Thomas

[tstuefe]

Ping. May I please have reviews, this patch is trivial.

Thanks!

[dcubed-ojdk]

The changes look simple enough.

I've kicked off a Mach5 Tier1 to make sure we don't have any Tier1 failures.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259569: gtest os.dll_address_to_function_and_library_name_vm fails

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• d7d34dd: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect
• fe84ecd: 8259048: (tz) Upgrade time-zone data to tzdata2020f
• 9aa5672: 8259068: Streamline class loader locking
• 27a39c8: 8193031: Collections.addAll is likely to perform worse than Collection.addAll
• 5855d52: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
• 360c722: 8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
• b78cd63: 8259846: [BACKOUT] JDK-8259278 Optimize Vector API slice and unslice operations
• eb7fa00: 8259216: javadoc omits method receiver for any nested type annotation
• bcf20a0: 8259777: Incorrect predication condition generated by ADLC
• bbac91a: 8257959: Add gtest run with -XX:+UseLargePages
• ... and 63 more: https://git.openjdk.java.net/jdk/compare/0957d9eb1452b953c1a700ce7ea41155c22bc00e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dcubed-ojdk]

Waiting for Mach5 Tier1 results before approving. Sorry for the confusion.

[dcubed-ojdk]

Tested with a Mach5 Tier1 job set.
No failures.
gtest/GTestWrapper.java ran in 8 different configs.

Verified that the os.dll_address_to_function_and_library_name_vm subtest passed on macOSX config:

[ RUN ] os.dll_address_to_function_and_library_name_vm
[ OK ] os.dll_address_to_function_and_library_name_vm (22 ms)

[dcubed-ojdk]

And I concur that this is a trivial change.

[tstuefe]

Thank you Dan!

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 76 commits pushed to the master branch:

• 536082d: Merge
• e85892b: 8258396: SIGILL in jdk.jfr.internal.PlatformRecorder.rotateDisk()
• d63388c: 8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr"
• d7d34dd: 8259799: vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 is incorrect
• fe84ecd: 8259048: (tz) Upgrade time-zone data to tzdata2020f
• 9aa5672: 8259068: Streamline class loader locking
• 27a39c8: 8193031: Collections.addAll is likely to perform worse than Collection.addAll
• 5855d52: 8259651: [macOS] Replace JNF_COCOA_ENTER/EXIT macros
• 360c722: 8259729: Missed JNFInstanceOf -> IsInstanceOf conversion
• b78cd63: 8259846: [BACKOUT] JDK-8259278 Optimize Vector API slice and unslice operations
• ... and 66 more: https://git.openjdk.java.net/jdk/compare/0957d9eb1452b953c1a700ce7ea41155c22bc00e...master

Your commit was automatically rebased without conflicts.

Pushed as commit 90c73d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.