8337723: Remove redundant tests from com/sun/security/sasl/gsskerb

[fguallini]

There are 3 manual GSS-API/Kerberos tests that require a manual setup and were added to the problem list years ago:

• com/sun/security/sasl/gsskerb/AuthOnly-> Verifies that both client and server have completed the authentication process.
• com/sun/security/sasl/gsskerb/NoSecurityLayer -> Attempts to use wrap and unwrap to demonstrate that these operations should not be allowed without a negotiated security layer.
• com/sun/security/sasl/gsskerb/ConfSecurityLayer -> Demonstrates the use of the security layer by wrapping and unwrapping messages on both client and server sides.

These tests need manual setup of a KDC environment, service/user principals, keytabs, JAAS configuration, and script adjustments. All that is time consuming and error prone. These do not fail if configured properly.

In contrast, the automated test sun/security/krb5/auto/SaslBasic already covers these scenarios and sets up the KDC with the necessary principals automatically, no manual setup is required. This class starts a simple KDC with one realm, several typical principal names, generates krb5.conf and keytab files, and setup a JAAS login config file.

I've enhanced SaslBasic to include additional wrap/unwrap checks with and without a security layer. As a result, the 3 manual tests and their associated files are now redundand and can be removed, as they no longer provide additional value.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337723: Remove redundant tests from com/sun/security/sasl/gsskerb (Bug - P5)

Reviewers

• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20464/head:pull/20464
$ git checkout pull/20464

Update a local copy of the PR:
$ git checkout pull/20464
$ git pull https://git.openjdk.org/jdk.git pull/20464/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20464

View PR using the GUI difftool:
$ git pr show -t 20464

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20464.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337723: Remove redundant tests from com/sun/security/sasl/gsskerb

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 178 new commits pushed to the master branch:

• 7a0832f: 8349934: Wrong file regex for copyright header format check in .jcheck/conf
• 2a5d1da: 8349571: Remove JavaThreadFactory interface from SA
• 74e458b: 8349684: Remove SA core file tests from problem list for macosx-x64
• ba28119: 8348427: DeferredLintHandler API should use JCTree instead of DiagnosticPosition
• c5ac3c4: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore
• 336d0d8: 8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c
• 4b463ee: 8342103: C2 compiler support for Float16 type and associated scalar operations
• 332d87c: 8349859: Support static JDK in libfontmanager/freetypeScaler.c
• 73e1780: 8349836: G1: Improve group prediction log message
• ed17c55: 8349145: Make Class.getProtectionDomain() non-native
• ... and 168 more: https://git.openjdk.org/jdk/compare/c3c3888762712e455757e4a52de8d680d58b8883...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fguallini The following labels will be automatically applied to this pull request:

• core-libs
• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

@fguallini Unknown command remove - for a list of valid commands use /help.

[fguallini]

/label remove core-libs

[openjdk]

@fguallini
The core-libs label was successfully removed.

[mlbridge]

Webrevs

• 04: Full (432f9c73)
• 03: Full (ea8b0235)
• 02: Full (e5413988)
• 01: Full (2072fa61)
• 00: Full (8f9b87e1)

[bridgekeeper]

@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[fguallini]

Hi,
if anyone is available, please review 🙏

[bridgekeeper]

@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[fguallini]

Bump, still looking for a review 🙏

[bridgekeeper]

@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@fguallini This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[fguallini]

/open

[openjdk]

@fguallini This pull request is now open

[openjdk]

@fguallini this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8337723
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

⚠️ @fguallini This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@fguallini Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[fguallini]

Force pushed to remove an incorrect commit from the branch

[rhalade]

Thanks for the update.

[fguallini]

/integrate

[openjdk]

@fguallini
Your change (at version 432f9c7) is now ready to be sponsored by a Committer.

[rhalade]

/sponsor

[openjdk]

Going to push as commit f979f72.
Since your change was applied there have been 271 commits pushed to the master branch:

• 1eb0db3: 8350151: Support requires property to filter tests incompatible with --enable-preview
• 1687373: 8349933: Mixing of includes and snippets stack causes the wrong -post snippet to be included
• 53db576: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools
• 10bf48a: 8350214: Test gtest/AsyncLogGtest.java fails after JDK-8349755
• 960ad21: 8349620: Add VMProps for static JDK
• 735805d: 8349727: [PPC] C1: Improve Class.isInstance intrinsic
• 1e87ff0: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
• 86d0616: 8350303: ARM32: StubCodeGenerator::verify_stub(StubGenStubId) failed after JDK-8343767
• 0662e39: 8350267: Set mtune and mcpu settings in JDK native lib compilation on Linux ppc64(le)
• c5c91a8: 8345285: [s390x] test failures: foreign/normalize/TestNormalize.java with C2
• ... and 261 more: https://git.openjdk.org/jdk/compare/c3c3888762712e455757e4a52de8d680d58b8883...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade @fguallini Pushed as commit f979f72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.