8257236: can't use var with a class named Z

[lahodaj]

To implements the local variable type inference, JShell needs to generate a few code snippets, which include an auxiliary type parameter and local variables. The name of the type parameter and variables may currently clash with names in the initializer of the variable. The proposal here is to generate a synthetic name, which won't clash with anything in the var's initializer.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8257236: can't use var with a class named Z

Reviewers

• Athijegannathan Sundararajan (@sundararajana - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2047/head:pull/2047
$ git checkout pull/2047

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5853585)

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257236: can't use var with a class named Z

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

• 563b268: 8257709: C1: Double assignment in InstructionPrinter::print_stack
• 400dc76: 8252015: [macos11] java.awt.TrayIcon requires updates for template images
• ac2dee5: 8259539: JDK-8255711 broke trap messages
• 4697cfa: 8259576: Misplaced curly brace in Matcher::find_shared_post_visit
• a6ab9e4: 8258576: Try to get zerobased CCS if heap is above 32 and CDS is disabled
• a3561ae: 8258243: C2: assert failed ("Bad derived pointer") with -XX:+VerifyRegisterAllocator
• 4663704: 8259583: Remove unused decode_env::_codeBuffer
• 9d4e84f: 8259565: Zero: compiler/runtime/criticalnatives fails because CriticalJNINatives is not supported
• 98ccfbf: 8255710: Opensource unit/regression tests for CMM
• 61c5b95: 7194219: java/awt/Component/UpdatingBootTime/UpdatingBootTime.html fails on Linux
• ... and 23 more: https://git.openjdk.java.net/jdk/compare/01b2804ef7211916ed3b7b40458b2aaccdbb5b01...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

@lahodaj Since your change was applied there have been 47 commits pushed to the master branch:

• 2243a17: 8259485: Document need for short paths when building on Windows
• 139b6da: 8259372: remove AIX related USE_LIBRARY_BASED_TLS_ONLY and THREAD_LOCAL special handling
• a483869: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64
• 44c8379: 8256019: JLabel HTML text does not support translucent text colors
• 0957d9e: 8259519: The java.awt.datatransfer.DataFlavor#ioInputStreamClass field is redundant
• 65bed64: 8253635: Implement toString() for SSLEngineImpl
• c6d798c: 8259629: aarch64 builds fail after JDK-8258932
• 4be2173: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
• e4df209: 7018932: Drawing very large coordinates with a dashed Stroke can cause Java to hang
• 5f7ccce: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
• ... and 37 more: https://git.openjdk.java.net/jdk/compare/01b2804ef7211916ed3b7b40458b2aaccdbb5b01...master

Your commit was automatically rebased without conflicts.

Pushed as commit 77ca103.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.