8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754

[jnimeh]

This proposed enhancement adds logging to the OCSPTimeout test, which is intermittently failing and difficult to reproduce. The hope is that with extra logging enabled that additional clues as to the cause of these rare failures will become apparent.

JBS: https://bugs.openjdk.org/browse/JDK-8337826

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754 (Enhancement - P3)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20471/head:pull/20471
$ git checkout pull/20471

Update a local copy of the PR:
$ git checkout pull/20471
$ git pull https://git.openjdk.org/jdk.git pull/20471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20471

View PR using the GUI difftool:
$ git pr show -t 20471

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20471.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jnimeh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jnimeh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

• a5c2d7b: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test
• 36d08c2: 8336846: assert(state->get_thread() == jt) failed: handshake unsafe conditions
• d19ba81: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true
• 21f710e: 8310675: Fix -Wconversion warnings in ZGC code
• 88a05a8: 8337975: [BACKOUT] Native memory leak when not recording any events
• 41f784f: 8335925: Serial: Move allocation API from Generation to subclasses
• 66286b2: 8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java
• 920751e: 8311990: Two JDI tests may interfere with each other
• 6733b89: 8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows
• fc652d2: 8235404: [macos] JOptionPane blocks drawing string on another component
• ... and 22 more: https://git.openjdk.org/jdk/compare/98562166e4a4c8921709014423c6cbc993aa0d97...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jnimeh]

/issue 8337826

[openjdk]

@jnimeh This issue is referenced in the PR title - it will now be updated.

[openjdk]

@jnimeh The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (558626be)
• 00: Full (077c8cbd)

[seanjmullan]

You should only include the bugid if the test is testing a specific bug fix. In this case, it is just additional debugging so no need to add it.

[jnimeh]

/integrate

[openjdk]

Going to push as commit 9b11bd7.
Since your change was applied there have been 33 commits pushed to the master branch:

• 5e021cb: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags
• a5c2d7b: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test
• 36d08c2: 8336846: assert(state->get_thread() == jt) failed: handshake unsafe conditions
• d19ba81: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true
• 21f710e: 8310675: Fix -Wconversion warnings in ZGC code
• 88a05a8: 8337975: [BACKOUT] Native memory leak when not recording any events
• 41f784f: 8335925: Serial: Move allocation API from Generation to subclasses
• 66286b2: 8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java
• 920751e: 8311990: Two JDI tests may interfere with each other
• 6733b89: 8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows
• ... and 23 more: https://git.openjdk.org/jdk/compare/98562166e4a4c8921709014423c6cbc993aa0d97...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jnimeh Pushed as commit 9b11bd7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.