Skip to content

Conversation

@dougxc
Copy link
Member

@dougxc dougxc commented Aug 6, 2024

This PR improves the documentation of jdk.vm.ci.code.Architecture.getName.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337887: [JVMCI] Clarify jdk.vm.ci.code.Architecture.getName javadoc (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20476/head:pull/20476
$ git checkout pull/20476

Update a local copy of the PR:
$ git checkout pull/20476
$ git pull https://git.openjdk.org/jdk.git pull/20476/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20476

View PR using the GUI difftool:
$ git pr show -t 20476

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20476.diff

Webrev

Link to Webrev Comment

/**
* Gets the name of this architecture.
*/
/// Gets the name of this architecture. The value returned for
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good opportunity to use the new markdown support for javadoc.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 6, 2024

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337887: [JVMCI] Clarify jdk.vm.ci.code.Architecture.getName javadoc

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 53db937: 8337780: RISC-V: C2: Change C calling convention for sp to NS
  • ab509f1: 8337654: Relocate uncommon trap stub from SharedRuntime to OptoRuntime
  • 1348ece: 8332120: Potential compilation failure in istream.cpp:205 - loss of data on conversion
  • ef909bd: 8335121: Native memory leak when not recording any events

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Aug 6, 2024
@dougxc dougxc marked this pull request as ready for review August 6, 2024 16:09
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 6, 2024

Webrevs

@dougxc
Copy link
Member Author

dougxc commented Aug 6, 2024

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 6, 2024

Going to push as commit 3f8b3e5.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 53db937: 8337780: RISC-V: C2: Change C calling convention for sp to NS
  • ab509f1: 8337654: Relocate uncommon trap stub from SharedRuntime to OptoRuntime
  • 1348ece: 8332120: Potential compilation failure in istream.cpp:205 - loss of data on conversion
  • ef909bd: 8335121: Native memory leak when not recording any events

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 6, 2024
@openjdk openjdk bot closed this Aug 6, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2024
@openjdk
Copy link

openjdk bot commented Aug 6, 2024

@dougxc Pushed as commit 3f8b3e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants