8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows

[plummercj]

Limit testing Compiler.perfmap and System.dump_map to just linux because they are only supported on linux.

Tested by running just this one test on linux-x64-debug, linux-aarch64-debug, macosx-aarch64, macosx-x64-debug, and windows-x64-debug

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows (Bug - P2)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)
• Kevin Walls (@kevinjwalls - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20480/head:pull/20480
$ git checkout pull/20480

Update a local copy of the PR:
$ git checkout pull/20480
$ git pull https://git.openjdk.org/jdk.git pull/20480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20480

View PR using the GUI difftool:
$ git pr show -t 20480

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20480.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows

Reviewed-by: stuefe, kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[plummercj]

/label serviceability

[openjdk]

@plummercj
The serviceability label was successfully added.

[tstuefe]

Good and trivial. Sorry for the trouble.

[mlbridge]

Webrevs

• 00: Full (0fe64bc4)

[kevinjwalls]

Looks good, thanks Chris!

[plummercj]

Thanks for the quick reviews Kevin and Thomas. I need to step out for an hour or two, so I'll wait until I come back before integrating.

[plummercj]

/integrate

[openjdk]

Going to push as commit 6733b89.
Since your change was applied there have been 3 commits pushed to the master branch:

• fc652d2: 8235404: [macos] JOptionPane blocks drawing string on another component
• 22a3421: 8337786: Fix simple -Wzero-as-null-pointer-constant warnings in aarch64 code
• ff634a9: 8337506: Disable "best-fit" mapping on Windows command line

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 6733b89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

Thanks for fixing this @plummercj