Skip to content

8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java #20485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Aug 7, 2024

Problem list until JDK-8330538 is fixed to reduce the noise in testing.

Thanks,
Tobias


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20485/head:pull/20485
$ git checkout pull/20485

Update a local copy of the PR:
$ git checkout pull/20485
$ git pull https://git.openjdk.org/jdk.git pull/20485/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20485

View PR using the GUI difftool:
$ git pr show -t 20485

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20485.diff

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 7, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java

Reviewed-by: chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2024
@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@TobiHartmann To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@TobiHartmann
Copy link
Member Author

Thanks Christian!

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Aug 7, 2024

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 7, 2024
@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@TobiHartmann
The hotspot-compiler label was successfully added.

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2024

Going to push as commit 66286b2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2024
@openjdk openjdk bot closed this Aug 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2024
@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@TobiHartmann Pushed as commit 66286b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Aug 7, 2024

Webrevs

@dougxc
Copy link
Member

dougxc commented Oct 24, 2024

Since this fails intermittently in 23u, I'm backporting it:

/backport jdk23u

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@dougxc the backport was successfully created on the branch backport-dougxc-66286b25-master in my personal fork of openjdk/jdk23u. To create a pull request with this backport targeting openjdk/jdk23u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 66286b25 from the openjdk/jdk repository.

The commit being backported was authored by Tobias Hartmann on 7 Aug 2024 and was reviewed by Christian Hagedorn.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk23u:

$ git fetch https://github.com/openjdk-bots/jdk23u.git backport-dougxc-66286b25-master:backport-dougxc-66286b25-master
$ git checkout backport-dougxc-66286b25-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk23u.git backport-dougxc-66286b25-master

⚠️ @dougxc You are not yet a collaborator in my fork openjdk-bots/jdk23u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants