-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java #20485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial
👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into |
@TobiHartmann This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@TobiHartmann To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
Thanks Christian! |
/label add hotspot-compiler |
@TobiHartmann |
/integrate |
Going to push as commit 66286b2. |
@TobiHartmann Pushed as commit 66286b2. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Since this fails intermittently in 23u, I'm backporting it: /backport jdk23u |
@dougxc the backport was successfully created on the branch backport-dougxc-66286b25-master in my personal fork of openjdk/jdk23u. To create a pull request with this backport targeting openjdk/jdk23u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk23u:
|
Problem list until JDK-8330538 is fixed to reduce the noise in testing.
Thanks,
Tobias
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20485/head:pull/20485
$ git checkout pull/20485
Update a local copy of the PR:
$ git checkout pull/20485
$ git pull https://git.openjdk.org/jdk.git pull/20485/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20485
View PR using the GUI difftool:
$ git pr show -t 20485
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20485.diff