Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed #20487

Closed
wants to merge 1 commit into from

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Aug 7, 2024

Hi, As described in the JDK-8331704 issue, there are some jvmci test cases that fail on linux-riscv64. we put the failed test cases into the Problem list until JDK-8331704 is fixed.

Please take a look and have some reviews. Thanks a lot.

Testing

  • Run hotspot:tier1 tests on SOPHON SG2042 (release)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20487/head:pull/20487
$ git checkout pull/20487

Update a local copy of the PR:
$ git checkout pull/20487
$ git pull https://git.openjdk.org/jdk.git pull/20487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20487

View PR using the GUI difftool:
$ git pr show -t 20487

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20487.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 7, 2024

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed

Reviewed-by: fyang, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 9b11bd7: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
  • 5e021cb: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags
  • a5c2d7b: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test
  • 36d08c2: 8336846: assert(state->get_thread() == jt) failed: handshake unsafe conditions
  • d19ba81: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true
  • 21f710e: 8310675: Fix -Wconversion warnings in ZGC code
  • 88a05a8: 8337975: [BACKOUT] Native memory leak when not recording any events
  • 41f784f: 8335925: Serial: Move allocation API from Generation to subclasses

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@zifeihan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@zifeihan zifeihan changed the title Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed 8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed Aug 7, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 7, 2024
@zifeihan
Copy link
Member Author

zifeihan commented Aug 7, 2024

/label add hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 7, 2024
@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@zifeihan
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 7, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 7, 2024
@zifeihan
Copy link
Member Author

zifeihan commented Aug 8, 2024

Thanks all for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@zifeihan
Your change (at version 5ed0820) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

Going to push as commit 16df9c3.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9b11bd7: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
  • 5e021cb: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags
  • a5c2d7b: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test
  • 36d08c2: 8336846: assert(state->get_thread() == jt) failed: handshake unsafe conditions
  • d19ba81: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true
  • 21f710e: 8310675: Fix -Wconversion warnings in ZGC code
  • 88a05a8: 8337975: [BACKOUT] Native memory leak when not recording any events
  • 41f784f: 8335925: Serial: Move allocation API from Generation to subclasses

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2024
@openjdk openjdk bot closed this Aug 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@RealFYang @zifeihan Pushed as commit 16df9c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zifeihan
Copy link
Member Author

/backport jdk23u

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@zifeihan the backport was successfully created on the branch backport-zifeihan-16df9c33-master in my personal fork of openjdk/jdk23u. To create a pull request with this backport targeting openjdk/jdk23u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 16df9c33 from the openjdk/jdk repository.

The commit being backported was authored by Gui Cao on 8 Aug 2024 and was reviewed by Fei Yang and Aleksey Shipilev.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk23u:

$ git fetch https://github.com/openjdk-bots/jdk23u.git backport-zifeihan-16df9c33-master:backport-zifeihan-16df9c33-master
$ git checkout backport-zifeihan-16df9c33-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk23u.git backport-zifeihan-16df9c33-master

@zifeihan zifeihan deleted the JDK-8337971 branch September 2, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants