-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337971: Problem list several jvmci tests on linux-riscv64 until JDK-8331704 is fixed #20487
Conversation
👋 Welcome back gcao! A progress list of the required criteria for merging this PR into |
@zifeihan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@zifeihan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label add hotspot-compiler |
@zifeihan |
Thanks all for the review. |
/sponsor |
Going to push as commit 16df9c3.
Your commit was automatically rebased without conflicts. |
@RealFYang @zifeihan Pushed as commit 16df9c3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
/backport jdk23u |
@zifeihan the backport was successfully created on the branch backport-zifeihan-16df9c33-master in my personal fork of openjdk/jdk23u. To create a pull request with this backport targeting openjdk/jdk23u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk23u:
|
Hi, As described in the JDK-8331704 issue, there are some jvmci test cases that fail on linux-riscv64. we put the failed test cases into the Problem list until JDK-8331704 is fixed.
Please take a look and have some reviews. Thanks a lot.
Testing
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20487/head:pull/20487
$ git checkout pull/20487
Update a local copy of the PR:
$ git checkout pull/20487
$ git pull https://git.openjdk.org/jdk.git pull/20487/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20487
View PR using the GUI difftool:
$ git pr show -t 20487
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20487.diff
Webrev
Link to Webrev Comment