Skip to content

8338015: Fix "Java Java" typo in package info file of java.lang.classfile #20505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Aug 8, 2024

Easy fix of an accidentally repeated "Java".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338015: Fix "Java Java" typo in package info file of java.lang.classfile (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20505/head:pull/20505
$ git checkout pull/20505

Update a local copy of the PR:
$ git checkout pull/20505
$ git pull https://git.openjdk.org/jdk.git pull/20505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20505

View PR using the GUI difftool:
$ git pr show -t 20505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20505.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 8, 2024

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338015: Fix "Java Java" typo in package info file of java.lang.classfile

Reviewed-by: jiefu, jpai, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 9b11bd7: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
  • 5e021cb: 8337410: The makefiles should set problemlist and adjust timeout basing on the given VM flags
  • a5c2d7b: 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test
  • 36d08c2: 8336846: assert(state->get_thread() == jt) failed: handshake unsafe conditions
  • d19ba81: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true
  • 21f710e: 8310675: Fix -Wconversion warnings in ZGC code
  • 88a05a8: 8337975: [BACKOUT] Native memory leak when not recording any events
  • 41f784f: 8335925: Serial: Move allocation API from Generation to subclasses
  • 66286b2: 8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8338015: Fix "Java Java" typo in package info file of java.lang.classfile 8338015: Fix "Java Java" typo in package info file of java.lang.classfile Aug 8, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 8, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 8, 2024

Webrevs

Copy link
Member

@DamonFool DamonFool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2024
@jddarcy
Copy link
Member Author

jddarcy commented Aug 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

Going to push as commit 78773b1.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2024
@openjdk openjdk bot closed this Aug 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@jddarcy Pushed as commit 78773b1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the JDK-8338015 branch October 17, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants