Skip to content

8338023: Support two vector selectFrom API #20508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from
Closed

8338023: Support two vector selectFrom API #20508

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
45bfe6c
8338023: Support two vector selectFrom API
Aug 8, 2024
82c0b0a
Adding Benchmark
Aug 8, 2024
055fb22
Review suggestions incorporated.
Aug 19, 2024
e24632c
Pass explicit wrap argument to selectFrom API with default value set …
Aug 21, 2024
d7ad688
Defaulting to index wrapping scheme.
Aug 23, 2024
6cb1a46
Removing redundant checkIndex routine
Aug 23, 2024
408a869
Review comments resolutions.
Aug 27, 2024
8d71f17
Adding descriptive comments
Aug 29, 2024
d3ee310
Review resolutions.
Sep 6, 2024
1c00f41
Documentation suggestions from Paul.
Sep 13, 2024
7c80bfc
Disabling VectorLoadShuffle bypassing optimization to comply with rea…
Sep 16, 2024
d72c82e
Review comments resolution.
Sep 17, 2024
2953004
Jcheck clearance
Sep 17, 2024
31a5864
Incorporating review and documentation suggestions.
Sep 18, 2024
42ca80c
Handling NPOT vector length for AArch64 SVE with vector sizes varying…
Sep 24, 2024
7327736
Review comments resolutions.
Oct 1, 2024
130fa3e
Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8338023
Oct 3, 2024
6215ab9
Review comments resolution.
Oct 3, 2024
1cca8e2
Sharpening intrinsic exit check.
Oct 3, 2024
79ee29c
Updating tests to use floorMod
Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2568,11 +2568,6 @@ final ByteVector selectFromTemplate(ByteVector v,
return v.rearrange(this.toShuffle(), m);
}

private static
IndexOutOfBoundsException checkIndexFailed(Vector<?> vix, int length) {
String msg = String.format("Range check failed: vector %s out of bounds for length %d", vix, length);
return new IndexOutOfBoundsException(msg);
}

/**
* {@inheritDoc} <!--workaround-->
Expand Down
5 changes: 0 additions & 5 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2410,11 +2410,6 @@ final DoubleVector selectFromTemplate(DoubleVector v,
return v.rearrange(this.toShuffle(), m);
}

private static
IndexOutOfBoundsException checkIndexFailed(Vector<?> vix, int length) {
String msg = String.format("Range check failed: vector %s out of bounds for length %d", vix, length);
return new IndexOutOfBoundsException(msg);
}

/**
* {@inheritDoc} <!--workaround-->
Expand Down
5 changes: 0 additions & 5 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2422,11 +2422,6 @@ final FloatVector selectFromTemplate(FloatVector v,
return v.rearrange(this.toShuffle(), m);
}

private static
IndexOutOfBoundsException checkIndexFailed(Vector<?> vix, int length) {
String msg = String.format("Range check failed: vector %s out of bounds for length %d", vix, length);
return new IndexOutOfBoundsException(msg);
}

/**
* {@inheritDoc} <!--workaround-->
Expand Down
5 changes: 0 additions & 5 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2553,11 +2553,6 @@ final IntVector selectFromTemplate(IntVector v,
return v.rearrange(this.toShuffle(), m);
}

private static
IndexOutOfBoundsException checkIndexFailed(Vector<?> vix, int length) {
String msg = String.format("Range check failed: vector %s out of bounds for length %d", vix, length);
return new IndexOutOfBoundsException(msg);
}

/**
* {@inheritDoc} <!--workaround-->
Expand Down
5 changes: 0 additions & 5 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,11 +2419,6 @@ final LongVector selectFromTemplate(LongVector v,
return v.rearrange(this.toShuffle(), m);
}

private static
IndexOutOfBoundsException checkIndexFailed(Vector<?> vix, int length) {
String msg = String.format("Range check failed: vector %s out of bounds for length %d", vix, length);
return new IndexOutOfBoundsException(msg);
}

/**
* {@inheritDoc} <!--workaround-->
Expand Down
5 changes: 0 additions & 5 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2569,11 +2569,6 @@ final ShortVector selectFromTemplate(ShortVector v,
return v.rearrange(this.toShuffle(), m);
}

private static
IndexOutOfBoundsException checkIndexFailed(Vector<?> vix, int length) {
String msg = String.format("Range check failed: vector %s out of bounds for length %d", vix, length);
return new IndexOutOfBoundsException(msg);
}

/**
* {@inheritDoc} <!--workaround-->
Expand Down
5 changes: 0 additions & 5 deletions src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2945,11 +2945,6 @@ public abstract class $abstractvectortype$ extends AbstractVector<$Boxtype$> {
return v.rearrange(this.toShuffle(), m);
}

private static
IndexOutOfBoundsException checkIndexFailed(Vector<?> vix, int length) {
String msg = String.format("Range check failed: vector %s out of bounds for length %d", vix, length);
return new IndexOutOfBoundsException(msg);
}

/**
* {@inheritDoc} <!--workaround-->
Expand Down