Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259631: Reapply pattern match instanceof use in HttpClientImpl #2051

Closed
wants to merge 1 commit into from

Conversation

@AlekseiEfimov
Copy link
Member

@AlekseiEfimov AlekseiEfimov commented Jan 12, 2021

Hi,

The proposed change adds back [1] instanceof pattern match use to HttpClientImpl class. It was previously removed by JDK-8258696 due to docs build failure.

Aleksei

[1] git rollback be41468c --no-commit


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259631: Reapply pattern match instanceof use in HttpClientImpl

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2051/head:pull/2051
$ git checkout pull/2051

…ntil docs-reference is fixed"

This reverts commit be41468.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 12, 2021

👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@AlekseiEfimov The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net label Jan 12, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 12, 2021

Webrevs

avivmu
avivmu approved these changes Jan 12, 2021
dfuch
dfuch approved these changes Jan 12, 2021
Copy link
Member

@dfuch dfuch left a comment

Approved - provided that tier1 tests are passing ;-)

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@AlekseiEfimov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259631: Reapply pattern match instanceof use in HttpClientImpl

Reviewed-by: dfuchs, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 535f2da: 8259486: Replace PreserveExceptionMark with implementation for CautiouslyPreserveExceptionMark
  • ce94512: 8259619: C1: 3-arg StubAssembler::call_RT stack-use condition is incorrect
  • 2e12454: 8259580: Shenandoah: uninitialized label in VerifyThreadGCState
  • 77ca103: 8257236: can't use var with a class named Z
  • 2243a17: 8259485: Document need for short paths when building on Windows
  • 139b6da: 8259372: remove AIX related USE_LIBRARY_BASED_TLS_ONLY and THREAD_LOCAL special handling
  • a483869: 8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64
  • 44c8379: 8256019: JLabel HTML text does not support translucent text colors
  • 0957d9e: 8259519: The java.awt.datatransfer.DataFlavor#ioInputStreamClass field is redundant
  • 65bed64: 8253635: Implement toString() for SSLEngineImpl
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/ccac7aaea380bc36c8dd0fe6e724c964489eeb6a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 12, 2021
@AlekseiEfimov
Copy link
Member Author

@AlekseiEfimov AlekseiEfimov commented Jan 14, 2021

/integrate

@openjdk openjdk bot closed this Jan 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@AlekseiEfimov Since your change was applied there have been 45 commits pushed to the master branch:

  • 3462f7a: 8256955: Move includes of events.hpp out of header files
  • 8b8b1f9: 8259706: C2 compilation fails with assert(vtable_index == Method::invalid_vtable_index) failed: correct sentinel value
  • ae9187d: 8256109: Create implementation for NSAccessibilityButton protocol
  • 5513f98: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy
  • 51e14f2: Merge
  • 5926d75: 8259719: ProblemList runtime/cds/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java on Windows
  • 8abefde: 8259720: ProblemList java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java on Windows
  • fb8ac24: 8259722: ProblemList two jdk/jfr/startupargs tests on Windows
  • ac4cd2e: 8231461: static/instance overload leads to 'unexpected static method found in unbound lookup' when resolving method reference
  • 42d2d6d: 8259063: Possible deadlock with vtable/itable creation vs concurrent class unloading
  • ... and 35 more: https://git.openjdk.java.net/jdk/compare/ccac7aaea380bc36c8dd0fe6e724c964489eeb6a...master

Your commit was automatically rebased without conflicts.

Pushed as commit b040a3d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants