8259629: aarch64 builds fail after JDK-8258932

[dgbo]

This fixes aarch64 builds failure after JDK-8258932.
It is caused by the mismatched call fmaxp/fminp in AssemblerAArch64 tests to the definitions in assembler_aarch64.hpp.

Verified with gtest-1.8.1 and make test TEST="gtest", linux-aarch64-server-slowdebug.
Both builds and tests are good, the results of gtest on my aarch64 server:

Finished running test 'gtest:all/server'
Test report is stored in build/linux-aarch64-server-slowdebug/test-results/gtest_all_server

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   gtest:all/server                                    807   807     0     0
==============================
TEST SUCCESS

Finished building target 'test' in configuration 'linux-aarch64-server-slowdebug'

The gtest was not configured during tests in JDK-8258932, so it did not execute previously.
I'm really sorry for my carelessness and producing a serious BUG.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259629: aarch64 builds fail after JDK-8258932

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2052/head:pull/2052
$ git checkout pull/2052

[bridgekeeper]

👋 Welcome back dongbo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dgbo To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• 2d
• awt
• beans
• build
• compiler
• core-libs
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah
• sound
• swing

[dgbo]

/label add hotspot-dev

[openjdk]

@dgbo
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 00: Full (6997dd9)

[dcubed-ojdk]

I'm testing this patch with linux-aarch64 Mach5 tier1.

[dcubed-ojdk]

The three build tasks (linux-aarch64, linux-aarch64-debug and linux-aarch64-open)
all passed. Tier1 testing is still running.

Update: The linux-aarch64 tier1 testing tasks passed.

[dcubed-ojdk]

@theRealAph - since you were the one reviewer on https://bugs.openjdk.java.net/browse/JDK-8258932
it would be good if you reviewed this build fix.

[vnkozlov]

It passed out whole tier1 testing I ran. So I am fine with it,

But I would like to see review from someone familiar with Aaarch64 assembler too.

[openjdk]

@dgbo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259629: aarch64 builds fail after JDK-8258932

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 4be2173: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
• e4df209: 7018932: Drawing very large coordinates with a dashed Stroke can cause Java to hang
• 5f7ccce: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
• d6a2105: 8259343: [macOS] Update JNI error handling in Cocoa code.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[vnkozlov]

After internal discussion and urgency we suggest to push this fix ASAP.
@dgbo please integrate it and I will sponsor.

[vnkozlov]

/integrate

[openjdk]

@vnkozlov Only the author (@dgbo) is allowed to issue the integrate command.

[dgbo]

Thank you all so much.
@vnkozlov Integrated.
/integrate

[openjdk]

@dgbo
Your change (at version 6997dd9) is now ready to be sponsored by a Committer.

[vnkozlov]

/sponsor

[openjdk]

@vnkozlov @dgbo Since your change was applied there have been 4 commits pushed to the master branch:

• 4be2173: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
• e4df209: 7018932: Drawing very large coordinates with a dashed Stroke can cause Java to hang
• 5f7ccce: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
• d6a2105: 8259343: [macOS] Update JNI error handling in Cocoa code.

Your commit was automatically rebased without conflicts.

Pushed as commit c6d798c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.