Skip to content

Conversation

@azvegint
Copy link
Member

@azvegint azvegint commented Aug 9, 2024

JDK-8337320 introduced the second mention of the java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java in problem list.

This causes the test to fail on MacOS


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20521/head:pull/20521
$ git checkout pull/20521

Update a local copy of the PR:
$ git checkout pull/20521
$ git pull https://git.openjdk.org/jdk.git pull/20521/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20521

View PR using the GUI difftool:
$ git pr show -t 20521

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20521.diff

Webrev

Link to Webrev Comment

@azvegint
Copy link
Member Author

azvegint commented Aug 9, 2024

/label client

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@azvegint
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Aug 9, 2024

Webrevs

@azvegint
Copy link
Member Author

azvegint commented Aug 9, 2024

/integrate

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

Going to push as commit 2b5aec2.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 9, 2024
@openjdk openjdk bot closed this Aug 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@azvegint Pushed as commit 2b5aec2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants