8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build

[sendaoYan]

Hi all,
The testcase testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build, the test log snippet says IR verification disabled due to not running a debug build. So I think it's need @requires vm.debug == true. And ths test will fail without c2 compiler, so it also need @requires vm.compiler2.enabled.

The change has been verified with linux x64 release build and linux x64 fastdebug build, no risk,

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build (Bug - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20524/head:pull/20524
$ git checkout pull/20524

Update a local copy of the PR:
$ git checkout pull/20524
$ git pull https://git.openjdk.org/jdk.git pull/20524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20524

View PR using the GUI difftool:
$ git pr show -t 20524

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20524.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 6a3d045: 8337709: Use allocated states for chunking large array processing
• 358d77d: 8337657: AArch64: No need for acquire fence in safepoint poll during JNI calls
• 60fa08f: 8337797: Additional ExternalAddress cleanup
• 3cf3f30: 8330191: Fix typo in precompiled.hpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[chhagedorn]

/label add hotspot-compiler

[openjdk]

@chhagedorn
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 02: Full - Incremental (292ad2a8)
• 01: Full - Incremental (537a9d1f)
• 00: Full (8bcf5c41)

[sendaoYan]

/label add hotspot-compiler

Thanks.

[TobiHartmann]

Looks good to me.

[chhagedorn]

Looks good, thanks!

[sendaoYan]

Thanks all for the review.
/integrate

[openjdk]

@sendaoYan
Your change (at version 292ad2a) is now ready to be sponsored by a Committer.

[DamonFool]

/sponsor

[openjdk]

Going to push as commit 0e7c1c1.
Since your change was applied there have been 4 commits pushed to the master branch:

• 6a3d045: 8337709: Use allocated states for chunking large array processing
• 358d77d: 8337657: AArch64: No need for acquire fence in safepoint poll during JNI calls
• 60fa08f: 8337797: Additional ExternalAddress cleanup
• 3cf3f30: 8330191: Fix typo in precompiled.hpp

Your commit was automatically rebased without conflicts.

[openjdk]

@DamonFool @sendaoYan Pushed as commit 0e7c1c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.