Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338060: jdk/internal/util/ReferencedKeyTest should be more robust #20527

Closed

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Aug 9, 2024

Addressing latent issues with ReferencedKeyTest

  • During the methods() tests the keys should be strongly held to avoid inadvertent GC collection and subsequent test failures (JDK-8336926)
  • Merge changes from Valhalla to use String (identity objects) for keys instead of Integer and Long that are value objects. (JDK-8336390)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338060: jdk/internal/util/ReferencedKeyTest should be more robust (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20527/head:pull/20527
$ git checkout pull/20527

Update a local copy of the PR:
$ git checkout pull/20527
$ git pull https://git.openjdk.org/jdk.git pull/20527/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20527

View PR using the GUI difftool:
$ git pr show -t 20527

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20527.diff

Webrev

Link to Webrev Comment

Addressing latent issues with ReferencedKeyTest
- During the `methods()` tests the keys should be strongly held to avoid
  inadvertent GC collection and subsequent test failures (JDK-8336926)
- Merge changes from Valhalla to use String (identity objects) for keys
  instead of Integer and Long that are value objects.
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338060: jdk/internal/util/ReferencedKeyTest should be more robust

Reviewed-by: never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • f84240b: 8338011: CDS archived heap object support for 64-bit Windows
  • 04b146a: 8337334: Test tools/javac/7142086/T7142086.java timeout with fastdebug binary
  • a36fb36: 8338108: Give better error message in configure if a full XCode is missing
  • 61d1dc5: 8334466: Ambiguous method call with generics may cause FunctionDescriptorLookupError
  • 89a15f1: 8337681: PNGImageWriter uses much more memory than necessary
  • a6c0630: 8337938: ZUtils::alloc_aligned allocates without reporting to NMT
  • 0320460: 8337958: Out-of-bounds array access in secondary_super_cache
  • 692f5cb: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058
  • 0e7c1c1: 8338112: Test testlibrary_tests/ir_framework/tests/TestPrivilegedMode.java fails with release build
  • 6a3d045: 8337709: Use allocated states for chunking large array processing
  • ... and 3 more: https://git.openjdk.org/jdk/compare/069e0ea69f43960164d3e077d2c7b950cde77927...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 9, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2024

Webrevs

Copy link
Contributor

@tkrodriguez tkrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 12, 2024
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

Going to push as commit b93b74e.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 41e31d6: 8337622: IllegalArgumentException in java.lang.reflect.Field.get
  • 2ca136a: 8337815: Relax G1EvacStats atomic operations
  • 99edb4a: 8337702: Use new ForwardExceptionNode to call StubRoutines::forward_exception_entry()
  • 8d08314: 8337795: Type annotation attached to incorrect type during class reading
  • f84240b: 8338011: CDS archived heap object support for 64-bit Windows
  • 04b146a: 8337334: Test tools/javac/7142086/T7142086.java timeout with fastdebug binary
  • a36fb36: 8338108: Give better error message in configure if a full XCode is missing
  • 61d1dc5: 8334466: Ambiguous method call with generics may cause FunctionDescriptorLookupError
  • 89a15f1: 8337681: PNGImageWriter uses much more memory than necessary
  • a6c0630: 8337938: ZUtils::alloc_aligned allocates without reporting to NMT
  • ... and 7 more: https://git.openjdk.org/jdk/compare/069e0ea69f43960164d3e077d2c7b950cde77927...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2024
@openjdk openjdk bot closed this Aug 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2024
@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@RogerRiggs Pushed as commit b93b74e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8338060-referencedkeytest-robust branch November 27, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants