Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226810: Failed to launch JVM because of NullPointerException occured on System.props #2053

Closed
wants to merge 1 commit into from

Conversation

@evwhelan
Copy link
Contributor

@evwhelan evwhelan commented Jan 12, 2021

Hi,

Please review this small change which enables the GB18030 charset to be built into java.base

Thanks


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8226810: Failed to launch JVM because of NullPointerException occured on System.props

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2053/head:pull/2053
$ git checkout pull/2053

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 12, 2021

👋 Welcome back ewhelan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@evwhelan The following labels will be automatically applied to this pull request:

  • build
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 12, 2021

Webrevs

@evwhelan evwhelan changed the title 8226810: Failed to launch JVM because of NullPointerException occurred on System.props 8226810: Failed to launch JVM because of NullPointerException occured on System.props Jan 12, 2021
@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 12, 2021

/labal add core-libs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 12, 2021

/label add core-libs

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 12, 2021

/label remove build

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@AlanBateman Unknown command labal - for a list of valid commands use /help.

@openjdk openjdk bot added the core-libs label Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@AlanBateman
The core-libs label was successfully added.

@openjdk openjdk bot removed the build label Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@AlanBateman
The build label was successfully removed.

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Including GB18030 in java.base rather than jdk.charsets on Windows is fine. It does increase the size of java.base but that is less of a concern now than it used to be.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@evwhelan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8226810: Failed to launch JVM because of NullPointerException occured on System.props

Reviewed-by: alanb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman, @naotoj) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 12, 2021
@evwhelan
Copy link
Contributor Author

@evwhelan evwhelan commented Jan 12, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@evwhelan
Your change (at version 5d3f0c5) is now ready to be sponsored by a Committer.

@naotoj
naotoj approved these changes Jan 12, 2021
Copy link
Member

@naotoj naotoj left a comment

Looks fine.

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 12, 2021

/spsonor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@AlanBateman Unknown command spsonor - for a list of valid commands use /help.

@AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Jan 12, 2021

/sponsor

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot removed the rfr label Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@AlanBateman @evwhelan Since your change was applied there has been 1 commit pushed to the master branch:

  • d6a2105: 8259343: [macOS] Update JNI error handling in Cocoa code.

Your commit was automatically rebased without conflicts.

Pushed as commit 5f7ccce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants