8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework

[kimbarrett]

Please review this change to remove -Wzero-as-null-pointer-constant warnings
produced by the gtest framework when such warnings are enabled.

Warnings from the 3rd party GoogleTest are suppressed by disabling that
warning when compiling those files.

Testing: mach5 tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework (Enhancement - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20536/head:pull/20536
$ git checkout pull/20536

Update a local copy of the PR:
$ git checkout pull/20536
$ git pull https://git.openjdk.org/jdk.git pull/20536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20536

View PR using the GUI difftool:
$ git pr show -t 20536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20536.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework

Reviewed-by: ihse, dholmes, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• e70c9bc: 8338248: PartialArrayStateAllocator::Impl leaks Arena array
• 5079c38: 8338160: Fix -Wzero-as-null-pointer-constant warnings in management.cpp
• 4417c27: 8330535: Update nsk/jdb tests to use driver instead of othervm
• b93b74e: 8338060: jdk/internal/util/ReferencedKeyTest should be more robust
• 41e31d6: 8337622: IllegalArgumentException in java.lang.reflect.Field.get
• 2ca136a: 8337815: Relax G1EvacStats atomic operations
• 99edb4a: 8337702: Use new ForwardExceptionNode to call StubRoutines::forward_exception_entry()
• 8d08314: 8337795: Type annotation attached to incorrect type during class reading
• f84240b: 8338011: CDS archived heap object support for 64-bit Windows
• 04b146a: 8337334: Test tools/javac/7142086/T7142086.java timeout with fastdebug binary
• ... and 7 more: https://git.openjdk.org/jdk/compare/6a3d045221c338fefec9bd59245324eae60b156b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following labels will be automatically applied to this pull request:

• build
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (da25196b)

[magicus]

Build change is trivially fine.

[dholmes-ora]

Looks good. Thanks

[kimbarrett]

Thanks for reviews @magicus , @TheShermanTanker , and @dholmes-ora

[kimbarrett]

/integrate

[openjdk]

Going to push as commit d77e6fe.
Since your change was applied there have been 17 commits pushed to the master branch:

• e70c9bc: 8338248: PartialArrayStateAllocator::Impl leaks Arena array
• 5079c38: 8338160: Fix -Wzero-as-null-pointer-constant warnings in management.cpp
• 4417c27: 8330535: Update nsk/jdb tests to use driver instead of othervm
• b93b74e: 8338060: jdk/internal/util/ReferencedKeyTest should be more robust
• 41e31d6: 8337622: IllegalArgumentException in java.lang.reflect.Field.get
• 2ca136a: 8337815: Relax G1EvacStats atomic operations
• 99edb4a: 8337702: Use new ForwardExceptionNode to call StubRoutines::forward_exception_entry()
• 8d08314: 8337795: Type annotation attached to incorrect type during class reading
• f84240b: 8338011: CDS archived heap object support for 64-bit Windows
• 04b146a: 8337334: Test tools/javac/7142086/T7142086.java timeout with fastdebug binary
• ... and 7 more: https://git.openjdk.org/jdk/compare/6a3d045221c338fefec9bd59245324eae60b156b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit d77e6fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.