8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp

[kimbarrett]

Please review this change to remove -Wzero-as-null-pointer-constant warnings
in jvmciCompilerToVM.cpp. We're changing uses of _0 suffixed exception macros
to instead use the corresponding _NULL suffixed macros where appropriate.

Testing: mach5 tier1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp (Enhancement - P4)

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)
• Doug Simon (@dougxc - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20538/head:pull/20538
$ git checkout pull/20538

Update a local copy of the PR:
$ git checkout pull/20538
$ git pull https://git.openjdk.org/jdk.git pull/20538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20538

View PR using the GUI difftool:
$ git pr show -t 20538

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20538.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp

Reviewed-by: tschatzl, jwaters, dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 21ca91e: 8300800: UB: Shift exponent 32 is too large for 32-bit type 'int'
• 58b9570: 8338142: (dc) DatagramChannelImpl.blockingReceive can use untimed-park when no timeout set
• 6af1d6f: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant
• 9e282e5: 8337998: CompletionFailure in getEnclosingType attaching type annotations
• 877fd5a: 8337595: Remove empty statements in src/hotspot/share/memory/metaspace
• 76e33b6: 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation
• ff8a9f9: 8337318: Deoptimization::relock_objects fails assert(monitor->owner() == Thread::current()) failed: must be
• fbe4cc9: 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when failing due to a LinkageError or other errors
• ba69ed7: 8338202: Shenandoah: Improve handshake closure labels
• 5bf2709: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set
• ... and 21 more: https://git.openjdk.org/jdk/compare/6a3d045221c338fefec9bd59245324eae60b156b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kimbarrett The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a97ee392)
• 00: Full (fdf8f929)

[tschatzl]

Unlike in the other cases, the indentation has not been updated. Looks good otherwise.

[kimbarrett]

In other cases I was maintaining pre-existing alignment. Here it was already formatted differently, and I
thought this was a file that used this indentation style (not that I like it). But looking around, I'm not
finding other uses of this style, so I've aligned the arguments.

[kimbarrett]

Thanks for reviews @tschatzl and @TheShermanTanker .

[kimbarrett]

Thanks for reviews @tschatzl , @TheShermanTanker , and @dougxc

[kimbarrett]

/integrate

[openjdk]

Going to push as commit ca99f37.
Since your change was applied there have been 32 commits pushed to the master branch:

• 84c3065: 8335865: Shenandoah: Improve THP pretouch after JDK-8315923
• 21ca91e: 8300800: UB: Shift exponent 32 is too large for 32-bit type 'int'
• 58b9570: 8338142: (dc) DatagramChannelImpl.blockingReceive can use untimed-park when no timeout set
• 6af1d6f: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant
• 9e282e5: 8337998: CompletionFailure in getEnclosingType attaching type annotations
• 877fd5a: 8337595: Remove empty statements in src/hotspot/share/memory/metaspace
• 76e33b6: 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation
• ff8a9f9: 8337318: Deoptimization::relock_objects fails assert(monitor->owner() == Thread::current()) failed: must be
• fbe4cc9: 8336384: AbstractQueuedSynchronizer.acquire should cancel acquire when failing due to a LinkageError or other errors
• ba69ed7: 8338202: Shenandoah: Improve handshake closure labels
• ... and 22 more: https://git.openjdk.org/jdk/compare/6a3d045221c338fefec9bd59245324eae60b156b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kimbarrett Pushed as commit ca99f37.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.