8338202: Shenandoah: Improve handshake closure labels

[shipilev]

Currently, Shenandoah has a few handshakes that have not very clear names, "ShenandoahRendezvous". Would be good to make them more explicit.

Before:

Event: 2.593 Executing VM operation: Shenandoah Init Marking
Event: 2.594 Executing VM operation: Shenandoah Init Marking done
Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake)
Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake) done
Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake)
Event: 2.599 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB Handshake) done
Event: 2.599 Executing VM operation: Shenandoah Final Mark and Start Evacuation
Event: 2.600 Executing VM operation: Shenandoah Final Mark and Start Evacuation done
Event: 2.600 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous)
Event: 2.600 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous) done
Event: 2.604 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous)
Event: 2.604 Executing VM operation: HandshakeAllThreads (ShenandoahRendezvous) done
Event: 2.605 Executing VM operation: CleanClassLoaderDataMetaspaces
Event: 2.606 Executing VM operation: CleanClassLoaderDataMetaspaces done
Event: 2.606 Executing VM operation: Shenandoah Init Update References
Event: 2.606 Executing VM operation: Shenandoah Init Update References done
Event: 2.611 Executing VM operation: HandshakeAllThreads (Shenandoah Update Thread Roots)
Event: 2.611 Executing VM operation: HandshakeAllThreads (Shenandoah Update Thread Roots) done
Event: 2.611 Executing VM operation: Shenandoah Final Update References
Event: 2.611 Executing VM operation: Shenandoah Final Update References done 

After:

Event: 1.043 Executing VM operation: Shenandoah Init Marking        
Event: 1.044 Executing VM operation: Shenandoah Init Marking done
Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB)
Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB) done
Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB)
Event: 1.050 Executing VM operation: HandshakeAllThreads (Shenandoah Flush SATB) done
Event: 1.050 Executing VM operation: Shenandoah Final Mark and Start Evacuation
Event: 1.050 Executing VM operation: Shenandoah Final Mark and Start Evacuation done
Event: 1.051 Executing VM operation: HandshakeAllThreads (Shenandoah Concurrent Weak Roots)
Event: 1.051 Executing VM operation: HandshakeAllThreads (Shenandoah Concurrent Weak Roots) done
Event: 1.055 Executing VM operation: Shenandoah Init Update References
Event: 1.055 Executing VM operation: Shenandoah Init Update References done
Event: 1.064 Executing VM operation: HandshakeAllThreads (Shenandoah Update Thread Roots)
Event: 1.064 Executing VM operation: HandshakeAllThreads (Shenandoah Update Thread Roots) done
Event: 1.064 Executing VM operation: Shenandoah Final Update References
Event: 1.064 Executing VM operation: Shenandoah Final Update References done

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338202: Shenandoah: Improve handshake closure labels (Enhancement - P4)

Reviewers

• Roman Kennke (@rkennke - Reviewer)
• Y. Srinivas Ramakrishna (@ysramakrishna - Reviewer)
• William Kemper (@earthling-amzn - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20549/head:pull/20549
$ git checkout pull/20549

Update a local copy of the PR:
$ git checkout pull/20549
$ git pull https://git.openjdk.org/jdk.git pull/20549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20549

View PR using the GUI difftool:
$ git pr show -t 20549

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20549.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338202: Shenandoah: Improve handshake closure labels

Reviewed-by: rkennke, ysr, wkemper

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 4417c27: 8330535: Update nsk/jdb tests to use driver instead of othervm
• b93b74e: 8338060: jdk/internal/util/ReferencedKeyTest should be more robust
• 41e31d6: 8337622: IllegalArgumentException in java.lang.reflect.Field.get
• 2ca136a: 8337815: Relax G1EvacStats atomic operations
• 99edb4a: 8337702: Use new ForwardExceptionNode to call StubRoutines::forward_exception_entry()
• 8d08314: 8337795: Type annotation attached to incorrect type during class reading
• f84240b: 8338011: CDS archived heap object support for 64-bit Windows
• 04b146a: 8337334: Test tools/javac/7142086/T7142086.java timeout with fastdebug binary
• a36fb36: 8338108: Give better error message in configure if a full XCode is missing
• 61d1dc5: 8334466: Ambiguous method call with generics may cause FunctionDescriptorLookupError
• ... and 2 more: https://git.openjdk.org/jdk/compare/03204600c596214895ef86581eba9722f76d39b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ba1cd746)

[rkennke]

Looks good to me, thank you!

[shipilev]

Thanks all!

/integrate

[openjdk]

Going to push as commit ba69ed7.
Since your change was applied there have been 19 commits pushed to the master branch:

• 5bf2709: 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set
• 73f7a5f: 8338155: Fix -Wzero-as-null-pointer-constant warnings involving PTHREAD_MUTEX_INITIALIZER
• c27a8c8: 8338124: C2 SuperWord: MulAddS2I input permutation still partially broken after JDK-8333840
• 73ddb7d: 8335628: C2 SuperWord: cleanup: remove SuperWord::longer_type_for_conversion
• d77e6fe: 8338154: Fix -Wzero-as-null-pointer-constant warnings in gtest framework
• e70c9bc: 8338248: PartialArrayStateAllocator::Impl leaks Arena array
• 5079c38: 8338160: Fix -Wzero-as-null-pointer-constant warnings in management.cpp
• 4417c27: 8330535: Update nsk/jdb tests to use driver instead of othervm
• b93b74e: 8338060: jdk/internal/util/ReferencedKeyTest should be more robust
• 41e31d6: 8337622: IllegalArgumentException in java.lang.reflect.Field.get
• ... and 9 more: https://git.openjdk.org/jdk/compare/03204600c596214895ef86581eba9722f76d39b3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit ba69ed7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.