New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259627: Potential memory leaks in JVMTI after JDK-8227745 #2055
8259627: Potential memory leaks in JVMTI after JDK-8227745 #2055
Conversation
|
@reinrich This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
@shipilev thanks for doing the analysis and reporting the issues. I found 2 leaks. Do you see more that could be related to JDK-8227745 (40f847e2)? I wanted to do a SonarCloud scan myself but was uncertain about the requested permissions, me using the service for work, etc. Would it be possible to publish the SC report? |
I think those are only two instances. I am only aware of this one. I meant to set up my own some time later. |
Excellent! I googled for public scans but failed. Now I see that scans are listed on the "Explore" page of SonarCloud. Cool the tool found the leaks! Thanks for the review also. |
Thanks for looking! |
Thanks for the reviews David and Serguei. |
/integrate |
@reinrich Since your change was applied there have been 66 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 6d4a593. |
This change eliminates memory leaks in the JVMTI implementation reported by SonarCloud.
The leaks occur when the Java heap is exhausted.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2055/head:pull/2055
$ git checkout pull/2055