8311530: Deprecate jdk.jsobject module for removal

[kevinrushforth]

Deprecate the jdk.jsobject module for removal from the JDK, and ship it with JavaFX instead.

See JDK-8337280 / PR openjdk/jfx#1529 for the JavaFX PR that will include the module with JavaFX. That PR describes the needed test scenarios.

This PR does two things:

1. Deprecates the jdk.jsobject module for removal; the javadoc indicates that the module will be delivered with JavaFX
2. Makes jdk.jsobject an upgradeable module, which will facilitate the transition by allowing the version of the module shipped with JavaFX to be used in favor of the deprecated module in the JDK itself.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8338250 to be approved
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

• JDK-8311530: Deprecate jdk.jsobject module for removal (Bug - P4)
• JDK-8338250: Deprecate jdk.jsobject module for removal (CSR)

Reviewers

• Roger Riggs (@RogerRiggs - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20555/head:pull/20555
$ git checkout pull/20555

Update a local copy of the PR:
$ git checkout pull/20555
$ git pull https://git.openjdk.org/jdk.git pull/20555/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20555

View PR using the GUI difftool:
$ git pr show -t 20555

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20555.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311530: Deprecate jdk.jsobject module for removal

Reviewed-by: rriggs, alanb, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• f7e8f50: 8341292: Open some TextArea awt tests 3
• fe83b7d: 8339341: SurfaceManager cacheMap retains strong references
• 12551ae: 8339975: Open some dialog awt tests 2
• 60af907: 8340494: Open some dialog awt tests 4
• 40a44e1: 8340851: Open some TextArea awt tests
• b993227: 8342119: Shenandoah: Remove extra ShenandoahUpdateRefsClosure
• 83e9e48: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @AlanBateman, @erikj79) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@kevinrushforth The following labels will be automatically applied to this pull request:

• build
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[kevinrushforth]

/label client

[openjdk]

@kevinrushforth
The client label was successfully added.

[kevinrushforth]

The GHA run shows a spurious failure in macOS (a network timeout cloning the repo). I'll rerun it with no changes to my branch.

[mlbridge]

Webrevs

• 03: Full - Incremental (e9eb8fb4)
• 02: Full - Incremental (7afc50ce)
• 01: Full - Incremental (d2ff851c)
• 00: Full (c3ee6ad3)

[RogerRiggs]

Looks good. I'll review the CSR when its ready.

[AlanBateman]

The changes to make jdk.jsobject an upgradeable module looks right.

I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.

[kevinrushforth]

Looks good. I'll review the CSR when its ready.

Thanks.

The changes to make jdk.jsobject an upgradeable module looks right.

Thanks for checking. My testing primarily focused on this aspect of the change, so it's pretty well tested.

I was initially surprised by the wording "will be delivered with JavaFX" but after playing with a few alternatives I concluded that what we have is okay.

Yeah, I tried a few variants and couldn't come up with anything better.

[AlanBateman]

@kevinrushforth Is the CSR on your list to write?

[kevinrushforth]

Yes, this was on hold for a couple weeks; I plan to write the CSR this week.

[kevinrushforth]

I've created the CSRs for both the this PR and openjdk/jfx#1529.

[erikj79]

Build change looks good.

/reviewers 2

[openjdk]

@erikj79
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

/integrate

[openjdk]

@kevinrushforth
Your change (at version e9eb8fb) is now ready to be sponsored by a Committer.

[RogerRiggs]

/sponsor

[openjdk]

Going to push as commit 2b03dbd.
Since your change was applied there have been 7 commits pushed to the master branch:

• f7e8f50: 8341292: Open some TextArea awt tests 3
• fe83b7d: 8339341: SurfaceManager cacheMap retains strong references
• 12551ae: 8339975: Open some dialog awt tests 2
• 60af907: 8340494: Open some dialog awt tests 4
• 40a44e1: 8340851: Open some TextArea awt tests
• b993227: 8342119: Shenandoah: Remove extra ShenandoahUpdateRefsClosure
• 83e9e48: 8325937: runtime/handshake/HandshakeDirectTest.java causes "monitor end should be strictly below the frame pointer" assertion failure on AArch64

Your commit was automatically rebased without conflicts.

[openjdk]

@RogerRiggs @kevinrushforth Pushed as commit 2b03dbd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.