8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

[jaikiran]

This is a fresh version of the PR that I had opened here #20442. A git merge command ended up causing unexpected issues with that old PR.

The commits in this PR are the ones which were already reviewed and a new one which was done to implement Daniel's suggestion in the review. test repeat 50 of java/net/httpclient had passed without any issues for that old PR. But before integrating this PR, I will rerun all relevant tests again to be sure nothing unexpected shows up.

Sorry that this has to be reviewed afresh.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient (Bug - P3)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20567/head:pull/20567
$ git checkout pull/20567

Update a local copy of the PR:
$ git checkout pull/20567
$ git pull https://git.openjdk.org/jdk.git pull/20567/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20567

View PR using the GUI difftool:
$ git pr show -t 20567

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20567.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 6af1d6f: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant
• 9e282e5: 8337998: CompletionFailure in getEnclosingType attaching type annotations
• 877fd5a: 8337595: Remove empty statements in src/hotspot/share/memory/metaspace
• 76e33b6: 8336148: Test runtime/locking/TestRecursiveMonitorChurn.java failed: Unexpected Inflation
• ff8a9f9: 8337318: Deoptimization::relock_objects fails assert(monitor->owner() == Thread::current()) failed: must be

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (fc7158c5)
• 00: Full (5040bf73)

[dfuch]

LGTM

[jaikiran]

Thank you Daniel for the review. tier testing and test repeat testing came back fine without any failures.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 720b446.
Since your change was applied there have been 12 commits pushed to the master branch:

• f132b34: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
• 90527a5: 8336742: Shenandoah: Add more verbose logging/stats for mark termination attempts
• 8e682ac: 8338158: Cleanup ShouldNotXXX uses in machnode.cpp
• ca99f37: 8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp
• 84c3065: 8335865: Shenandoah: Improve THP pretouch after JDK-8315923
• 21ca91e: 8300800: UB: Shift exponent 32 is too large for 32-bit type 'int'
• 58b9570: 8338142: (dc) DatagramChannelImpl.blockingReceive can use untimed-park when no timeout set
• 6af1d6f: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant
• 9e282e5: 8337998: CompletionFailure in getEnclosingType attaching type annotations
• 877fd5a: 8337595: Remove empty statements in src/hotspot/share/memory/metaspace
• ... and 2 more: https://git.openjdk.org/jdk/compare/fbe4cc96e223882a18c7ff666fe6f68b3fa2cfe4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 720b446.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.