Skip to content

Conversation

@walulyai
Copy link
Member

@walulyai walulyai commented Aug 13, 2024

Please review this trivial change to remove an unused parameter worker_id in G1CardTableEntryClosure:do_card_ptr.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338315: G1: G1CardTableEntryClosure:do_card_ptr remove unused parameter worker_id (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20569/head:pull/20569
$ git checkout pull/20569

Update a local copy of the PR:
$ git checkout pull/20569
$ git pull https://git.openjdk.org/jdk.git pull/20569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20569

View PR using the GUI difftool:
$ git pr show -t 20569

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20569.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2024

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@walulyai This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338315: G1: G1CardTableEntryClosure:do_card_ptr remove unused parameter worker_id

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 3dd07b9: 8336163: Remove declarations of some debug-only methods in release build
  • 720b446: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient
  • f132b34: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • 90527a5: 8336742: Shenandoah: Add more verbose logging/stats for mark termination attempts
  • 8e682ac: 8338158: Cleanup ShouldNotXXX uses in machnode.cpp
  • ca99f37: 8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp
  • 84c3065: 8335865: Shenandoah: Improve THP pretouch after JDK-8315923
  • 21ca91e: 8300800: UB: Shift exponent 32 is too large for 32-bit type 'int'
  • 58b9570: 8338142: (dc) DatagramChannelImpl.blockingReceive can use untimed-park when no timeout set
  • 6af1d6f: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant
  • ... and 3 more: https://git.openjdk.org/jdk/compare/ff8a9f9267c480fe0be8470cda870fd77763fb31...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@walulyai The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Aug 13, 2024
@walulyai walulyai marked this pull request as ready for review August 13, 2024 17:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 13, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2024

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 14, 2024
@walulyai
Copy link
Member Author

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

Going to push as commit 66bee25.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 3dd07b9: 8336163: Remove declarations of some debug-only methods in release build
  • 720b446: 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient
  • f132b34: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • 90527a5: 8336742: Shenandoah: Add more verbose logging/stats for mark termination attempts
  • 8e682ac: 8338158: Cleanup ShouldNotXXX uses in machnode.cpp
  • ca99f37: 8338156: Fix -Wzero-as-null-pointer-constant warnings in jvmciCompilerToVM.cpp
  • 84c3065: 8335865: Shenandoah: Improve THP pretouch after JDK-8315923
  • 21ca91e: 8300800: UB: Shift exponent 32 is too large for 32-bit type 'int'
  • 58b9570: 8338142: (dc) DatagramChannelImpl.blockingReceive can use untimed-park when no timeout set
  • 6af1d6f: 8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant
  • ... and 3 more: https://git.openjdk.org/jdk/compare/ff8a9f9267c480fe0be8470cda870fd77763fb31...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2024
@openjdk openjdk bot closed this Aug 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@walulyai Pushed as commit 66bee25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants