Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253244: Shenandoah: cleanup includes in Shenandoah root processor files #206

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Sep 16, 2020

Many roots were moved to oop storages, Shenandoah root processor no longer references to StringTable, systemDictionary and ResolvedMethodTable, etc.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253244: Shenandoah: cleanup includes in Shenandoah root processor files

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/206/head:pull/206
$ git checkout pull/206

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2020

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@zhengyu123 The following labels will be automatically applied to this pull request: hotspot-gc shenandoah.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added hotspot-gc shenandoah labels Sep 16, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2020

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Looks fine. Please try with {release, fastdebug, slowdebug} x {-PCH, +PCH}?

I use scripts like these:

`#!/bin/bash

set -euo pipefail

for M in release fastdebug slowdebug; do
sh ./configure --with-debug-level=$M --with-boot-jdk=/home/shade/Install/jdk14-ea/
CONF=linux-x86_64-server-$M make clean images

sh ./configure --with-debug-level=$M --with-boot-jdk=/home/shade/Install/jdk14-ea/ --disable-precompiled-headers
CONF=linux-x86_64-server-$M make clean images
done
`

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@zhengyu123 This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253244: Shenandoah: cleanup includes in Shenandoah root processor files

Reviewed-by: shade
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 37 commits pushed to the master branch:

  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/68da63dcdead52418b41f80d381b105ce71a8162...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate d38c97dd52966ecf53d963829b8c9df916eb096b.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 16, 2020
@zhengyu123 zhengyu123 closed this Sep 16, 2020
@zhengyu123 zhengyu123 reopened this Sep 16, 2020
@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Sep 16, 2020

Looks fine. Please try with {release, fastdebug, slowdebug} x {-PCH, +PCH}?

I use scripts like these:

`#!/bin/bash

set -euo pipefail

for M in release fastdebug slowdebug; do
sh ./configure --with-debug-level=$M --with-boot-jdk=/home/shade/Install/jdk14-ea/
CONF=linux-x86_64-server-$M make clean images

sh ./configure --with-debug-level=$M --with-boot-jdk=/home/shade/Install/jdk14-ea/ --disable-precompiled-headers
CONF=linux-x86_64-server-$M make clean images
done
`

All fine.

@zhengyu123
Copy link
Contributor Author

@zhengyu123 zhengyu123 commented Sep 16, 2020

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@zhengyu123 Since your change was applied there have been 37 commits pushed to the master branch:

  • d38c97d: 8253207: enable problemlists jcheck's check
  • 671dfba: 6714834: JarFile.getManifest() leaves an open InputStream as an undocumented side effect
  • e5866aa: 8244706: GZIP "OS" header flag hard-coded to 0 instead of 255 (RFC 1952 non-compliance)
  • 1086713: 8253206: Enforce whitespace checking for additional source files
  • e2196f8: 8253162: Make frame::oops_do const
  • 300b851: 8253226: Shenandoah: remove unimplemented ShenandoahStrDedupQueue::verify
  • c781594: 8253224: Shenandoah: ShenandoahStrDedupQueue destructor calls virtual num_queues()
  • 33f8e70: 8253173: Print heap before and after GC lacks a newline
  • f509eb0: 8253219: Epsilon: clean up unnecessary includes
  • 7f9b5d9: 8253220: Epsilon: clean up unused code/declarations
  • ... and 27 more: https://git.openjdk.java.net/jdk/compare/68da63dcdead52418b41f80d381b105ce71a8162...master

Your commit was automatically rebased without conflicts.

Pushed as commit d250f9e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zhengyu123 zhengyu123 deleted the JDK-8253244 branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated shenandoah
2 participants