New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8253244: Shenandoah: cleanup includes in Shenandoah root processor files #206
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
@zhengyu123 The following labels will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Please try with {release, fastdebug, slowdebug} x {-PCH, +PCH}?
I use scripts like these:
`#!/bin/bash
set -euo pipefail
for M in release fastdebug slowdebug; do
sh ./configure --with-debug-level=$M --with-boot-jdk=/home/shade/Install/jdk14-ea/
CONF=linux-x86_64-server-$M make clean images
sh ./configure --with-debug-level=$M --with-boot-jdk=/home/shade/Install/jdk14-ea/ --disable-precompiled-headers
CONF=linux-x86_64-server-$M make clean images
done
`
@zhengyu123 This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 37 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
All fine. |
/integrate |
@zhengyu123 Since your change was applied there have been 37 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit d250f9e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Many roots were moved to oop storages, Shenandoah root processor no longer references to StringTable, systemDictionary and ResolvedMethodTable, etc.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/206/head:pull/206
$ git checkout pull/206