8338543: ClassBuilder withMethod builders should cache the method type symbol

[liach]

In #20611 and other investigations, we noted that MethodTypeDesc.ofDescriptor is unnecessarily called due to missing caching in ClassBuilder. This patch adds that missing caching functionality.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338543: ClassBuilder withMethod builders should cache the method type symbol (Sub-task - P4)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20627/head:pull/20627
$ git checkout pull/20627

Update a local copy of the PR:
$ git checkout pull/20627
$ git pull https://git.openjdk.org/jdk.git pull/20627/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20627

View PR using the GUI difftool:
$ git pr show -t 20627

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20627.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338543: ClassBuilder withMethod builders should cache the method type symbol

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (230caae9)

[asotona]

Looks good to me, do you have any benchmark numbers?

[liach]

I tested by adding a System.out.println to MethodTypeDesc.ofDescriptor and it printed nothing locally when running this little program including string concat and lambda with java Ape (Note that java Ape.java will print gibberish once`, didn't diagnose that one yet):

public interface Ape {
    static void main(String... args) {
        Runnable a = () -> {
            System.out.println("asd[" + args[0] + "foo" + args[1]);
        };
        a.run();
    }
}

Before a cache miss call looked like this: #20611 (comment)

[liach]

Thanks for the review. Integrating to facilitate other startup optimization patches dependent on changes here.

/integrate

[openjdk]

Going to push as commit 68d1f5c.
Since your change was applied there have been 3 commits pushed to the master branch:

• 55851a3: 8281533: Odd "preview" label in link/linkplain
• c7690c3: 8338190: TOC vertical offsets not updated when document size changes
• 6460b30: 8321140: Add comment to note difference in Metal's JButton margins

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit 68d1f5c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.