8328880: Events::log_exception should limit the size of the logging message

[dholmes-ora]

This simple enhancement allows for Exceptions::_throw to limit the message length printed by Events::log_exception in the same way that unified logging is limited. We simply allow a message_length_limit variable to be passed down - default value zero which means no limit (i.e. the full strlen of the message will be printed).

Testing:

• tiers 1-3

Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8328880: Events::log_exception should limit the size of the logging message (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20638/head:pull/20638
$ git checkout pull/20638

Update a local copy of the PR:
$ git checkout pull/20638
$ git pull https://git.openjdk.org/jdk.git pull/20638/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20638

View PR using the GUI difftool:
$ git pr show -t 20638

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20638.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328880: Events::log_exception should limit the size of the logging message

Reviewed-by: shade, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• c89a1c3: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
• 813546f: 8338856: [BACKOUT] JDK-8337828: CDS: Trim down minimum GC region alignment
• 0b5c887: 8338380: Update TLSCommon/interop/AbstractServer to specify an interface to listen for connections
• 6041c93: 8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds
• 6cf7f9c: 8338662: Shenandoah: Remove excessive ShenandoahVerifier::verify_during_evacuation
• 129f527: 8338290: Xcode project generator for hotspot
• 6644dd3: 8338760: Adjust the comment after UseObjectMonitorTable
• 1d05989: 8334357: Use NonInterleavingLogStream for report_metadata_oome
• 47c8a6a: 8333265: De-duplicate method references in java.util.stream.FindOps
• ab8071d: 8338146: Improve Exchanger performance with VirtualThreads
• ... and 27 more: https://git.openjdk.org/jdk/compare/55851a312baaea5af14c04fb1b436313fe0deac7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dholmes-ora The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a59c589b)

[shipilev]

Looks reasonable. (First time I see %.*s, this is a cute trick I did not know about before.)

[dholmes-ora]

Thanks for the review @shipilev !

[dholmes-ora]

Thanks for the review @vnkozlov !

/integrate

[openjdk]

Going to push as commit ea33709.
Since your change was applied there have been 37 commits pushed to the master branch:

• c89a1c3: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
• 813546f: 8338856: [BACKOUT] JDK-8337828: CDS: Trim down minimum GC region alignment
• 0b5c887: 8338380: Update TLSCommon/interop/AbstractServer to specify an interface to listen for connections
• 6041c93: 8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds
• 6cf7f9c: 8338662: Shenandoah: Remove excessive ShenandoahVerifier::verify_during_evacuation
• 129f527: 8338290: Xcode project generator for hotspot
• 6644dd3: 8338760: Adjust the comment after UseObjectMonitorTable
• 1d05989: 8334357: Use NonInterleavingLogStream for report_metadata_oome
• 47c8a6a: 8333265: De-duplicate method references in java.util.stream.FindOps
• ab8071d: 8338146: Improve Exchanger performance with VirtualThreads
• ... and 27 more: https://git.openjdk.org/jdk/compare/55851a312baaea5af14c04fb1b436313fe0deac7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dholmes-ora Pushed as commit ea33709.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.