-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods #20643
8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods #20643
Conversation
👋 Welcome back stefank! A progress list of the required criteria for merging this PR into |
@stefank This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@stefank The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label remove core-libs |
@stefank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good.
Thanks for the review |
Going to push as commit 9ad2e63. |
Thumbs up. Re-reviewed via GitHub and compared |
Hi all,
This pull request contains a backport of commit 9775d571 from the openjdk/jdk repository.
The commit being backported was authored by Stefan Karlsson on 20 Aug 2024 and was reviewed by Leonid Mesnik, Daniel D. Daugherty and David Holmes.
Thanks!
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20643/head:pull/20643
$ git checkout pull/20643
Update a local copy of the PR:
$ git checkout pull/20643
$ git pull https://git.openjdk.org/jdk.git pull/20643/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20643
View PR using the GUI difftool:
$ git pr show -t 20643
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20643.diff
Webrev
Link to Webrev Comment