Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods #20643

Closed

Conversation

stefank
Copy link
Member

@stefank stefank commented Aug 20, 2024

Hi all,

This pull request contains a backport of commit 9775d571 from the openjdk/jdk repository.

The commit being backported was authored by Stefan Karlsson on 20 Aug 2024 and was reviewed by Leonid Mesnik, Daniel D. Daugherty and David Holmes.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8338540 to be approved

Issues

  • JDK-8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods (Bug - P1)
  • JDK-8338540: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20643/head:pull/20643
$ git checkout pull/20643

Update a local copy of the PR:
$ git checkout pull/20643
$ git pull https://git.openjdk.org/jdk.git pull/20643/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20643

View PR using the GUI difftool:
$ git pr show -t 20643

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20643.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2024

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods

Reviewed-by: kevinw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9775d57168695dc0d758e017fe5069d93d593f3e 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@stefank The following labels will be automatically applied to this pull request:

  • core-libs
  • hotspot-runtime
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Aug 20, 2024
@stefank
Copy link
Member Author

stefank commented Aug 20, 2024

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@stefank
The core-libs label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Aug 20, 2024

Webrevs

Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 20, 2024
@stefank
Copy link
Member Author

stefank commented Aug 20, 2024

Thanks for the review
/integrate

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

Going to push as commit 9ad2e63.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 20, 2024
@openjdk openjdk bot closed this Aug 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@stefank Pushed as commit 9ad2e63.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk
Copy link
Member

Thumbs up. Re-reviewed via GitHub and compared
the JDK24 patch file with the JDK23 patch file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants