New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8259723: Move Table class to formats.html package #2065
Conversation
|
@jonathan-gibbons The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
A not-reasonable extension of this change would be to move |
@jonathan-gibbons This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
1 similar comment
/integrate |
@jonathan-gibbons Since your change was applied there have been 33 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 1620664. |
@jonathan-gibbons The command |
Please review this change to just move two classes from one package to another. The move was done as a single simple IDE operation, which also had a not-unwelcome side-effect of cleaning up some unrelated imports.
The change is an indirect consequence of the recent change to use the new
HtmlId
andHtmlIds
classes, which introduced an undesirable package dependence in theTable
class.The changes are just to move the classes and update imports. There are no functional changes.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2065/head:pull/2065
$ git checkout pull/2065