Skip to content

8338694: x86_64 intrinsic for tanh using libm #20657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

8338694: x86_64 intrinsic for tanh using libm #20657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0328101
8338694: x86_64 intrinsic for tanh using libm
vamsi-parasa Aug 21, 2024
79766f1
Fix bug in NaN path
vamsi-parasa Aug 22, 2024
4739ad4
Add stub initialization and extra tanh tests
vamsi-parasa Aug 30, 2024
39350a3
update libm tanh reference test with code review suggestions
vamsi-parasa Sep 5, 2024
4aa52bf
c1 and template generator fixes
vamsi-parasa Sep 11, 2024
d4ddc31
quad precision tanh tests
vamsi-parasa Sep 13, 2024
ca3314c
Update test/jdk/java/lang/Math/HyperbolicTests.java
vamsi-parasa Sep 13, 2024
c151123
remove tanh tests in seprate file
vamsi-parasa Sep 16, 2024
d249508
update copyright year and remove unused random from HyperbolicTests
vamsi-parasa Sep 16, 2024
e908eb4
Update HyperbolicTests.java
vamsi-parasa Sep 16, 2024
7416537
Merge branch 'master' of https://git.openjdk.java.net/jdk into onetanh
vamsi-parasa Sep 16, 2024
3664be1
update tanh additional tests
vamsi-parasa Sep 16, 2024
b438555
Merge branch 'master' of https://git.openjdk.java.net/jdk into onetanh
vamsi-parasa Sep 16, 2024
1ee4c1f
add call to the additional tests
vamsi-parasa Sep 17, 2024
aa16389
remove -ve tests
vamsi-parasa Sep 17, 2024
5da2754
fix is_intrinsic_supported to work properly
vamsi-parasa Sep 19, 2024
4dc2e36
change ifdef from x86 to AMD64
vamsi-parasa Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,11 @@ void LIRGenerator::do_MathIntrinsic(Intrinsic* x) {
if (x->id() == vmIntrinsics::_dexp || x->id() == vmIntrinsics::_dlog ||
x->id() == vmIntrinsics::_dpow || x->id() == vmIntrinsics::_dcos ||
x->id() == vmIntrinsics::_dsin || x->id() == vmIntrinsics::_dtan ||
x->id() == vmIntrinsics::_dlog10 || x->id() == vmIntrinsics::_dtanh) {
x->id() == vmIntrinsics::_dlog10
#ifdef _LP64
|| x->id() == vmIntrinsics::_dtanh
#endif
) {
do_LibmIntrinsic(x);
return;
}
Expand Down Expand Up @@ -995,9 +999,10 @@ void LIRGenerator::do_LibmIntrinsic(Intrinsic* x) {
}
break;
case vmIntrinsics::_dtanh:
assert(StubRoutines::dtanh() != nullptr, "tanh intrinsic not found");
if (StubRoutines::dtanh() != nullptr) {
__ call_runtime_leaf(StubRoutines::dtanh(), getThreadTemp(), result_reg, cc->args());
} // TODO: else clause?
}
break;
default: ShouldNotReachHere();
}
Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/cpu/x86/templateInterpreterGenerator_x86_32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2024, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down