8338728: Misc issues in memory layout javadoc

[mcimadamore]

This PR fixes two minor issues in the MemoryLayout javadoc:

• the section describing dereference path talks about P and P' but then only uses P in the code;
• the ceilDiv math on the PathElement::sequenceElement(long, long) is wrong, as the division returns a negative number for F < 0, which is incorrect

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338728: Misc issues in memory layout javadoc (Enhancement - P4)

Reviewers

• Per Minborg (@minborg - Reviewer)
• Paul Sandoz (@PaulSandoz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20659/head:pull/20659
$ git checkout pull/20659

Update a local copy of the PR:
$ git checkout pull/20659
$ git pull https://git.openjdk.org/jdk.git pull/20659/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20659

View PR using the GUI difftool:
$ git pr show -t 20659

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20659.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338728: Misc issues in memory layout javadoc

Reviewed-by: pminborg, psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 109 new commits pushed to the master branch:

• 16df090: 8338947: Deprecate the UseLinuxPosixThreadCPUClocks flag and remove it in a future release
• a827ff0: 8335577: runtime/cds/appcds/TestParallelGCWithCDS.java still fails with JNI error
• 5ecbecf: 8338936: StringConcatFactory optimize the construction of MethodType and MethodTypeDesc
• 0c744ea: 8338928: Update SwingSet2 "About" image to reference openjdk.org
• a15af69: 8338538: [JVMCI] Allow HotSpotJVMCIRuntime#getJObjectValue to be called by a HotSpot CompileBroker compiler thread
• 3f00da8: 8338906: Avoid passing EnumDescs and extra classes to type switch methods that don't use them
• e63418e: 8338979: Avoid bootstrapped switches in the classfile API
• 20d8f58: 8331671: Implement JEP 472: Prepare to Restrict the Use of JNI
• ce83f6a: 8338844: C2: remove useless code in PhaseIdealLoop::place_outside_loop() after 8335709
• 0c14579: 8336830: C2: assert(get_loop(lca)->_nest < n_loop->_nest || lca->in(0)->is_NeverBranch()) failed: must not be moved into inner loop
• ... and 99 more: https://git.openjdk.org/jdk/compare/38bd8a36704a962f0ad1052fd2ec150a61663256...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mcimadamore The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8079981b)
• 00: Full (8a8b0c7b)

[minborg]

LGTM. Nice with a test even though just for documentation validation.

[mcimadamore]

/integrate

[openjdk]

Going to push as commit b25095b.
Since your change was applied there have been 117 commits pushed to the master branch:

• 414d23c: 8338765: ScheduledThreadPoolExecutor struggles with extremely long delays
• d5c6158: 8338389: [JFR] Long strings should be added to the string pool
• 2edf574: 8338814: [PPC64] Unify interface of cmpxchg for different types
• aefdbdc: 8338727: RISC-V: Avoid synthetic data dependency in nmethod barrier on Ztso
• b704bfa: 8298920: Improve microbenchmark build times
• b8e8e96: 8338668: Test javax/swing/JFileChooser/8080628/bug8080628.java doesn't test for GTK L&F
• cd9e241: 8336289: Obliterate most references to _snprintf in the Windows JDK
• 78f53ef: 8338938: The result of the combine method of SettingsControl is not used
• 16df090: 8338947: Deprecate the UseLinuxPosixThreadCPUClocks flag and remove it in a future release
• a827ff0: 8335577: runtime/cds/appcds/TestParallelGCWithCDS.java still fails with JNI error
• ... and 107 more: https://git.openjdk.org/jdk/compare/38bd8a36704a962f0ad1052fd2ec150a61663256...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mcimadamore Pushed as commit b25095b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.