8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #20687

sendaoYan · 2024-08-23T03:58:37Z

Hi all,
On alinux3(alibaba cloud linux version 3) system, the /tmp disk partition is mounted as tmpfs filesystem type, this filesystem type doesn't support create time(birth time).

Before this PR, this test check if there is statx system call present or not to determise the test environment support birth time or not. I think it's not enough when the tested filesystem type is tmpfs. When the tested filesystem type is tmpfs, then the tested file doesn't support birth time.

On RHEL 8 tmpfs doesn't seem to support birth time, but on F39 tmpfs does seem to support birth time. Looks like this might be related to the kernel version. It's difficult to enumerate all the combination of file system type and linux kernel version to determine the testd file support birth time or not. So in this PR, I get the result from statx linux syscall, to determine the testd file support birth time or not.

Test fix only, the change has been verified, risk is low.

Additional test:

Alinux3 glibc:2.32

/tmp/file supportsCreationTimeRead == false
./file supportsCreationTimeRead == true

CentOS7 docker container glibc:2.17

/tmp/file supportsCreationTimeRead == false
./file supportsCreationTimeRead == false

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 (Bug - P3)

Reviewers

Severin Gehwolf (@jerboaa - Reviewer)
Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20687/head:pull/20687
$ git checkout pull/20687

Update a local copy of the PR:
$ git checkout pull/20687
$ git pull https://git.openjdk.org/jdk.git pull/20687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20687

View PR using the GUI difftool:
$ git pr show -t 20687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20687.diff

Webrev

Link to Webrev Comment

…linux3 after JDK-8338696

bridgekeeper · 2024-08-23T03:59:19Z

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-08-23T04:00:06Z

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3

Reviewed-by: sgehwolf, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 618 new commits pushed to the master branch:

38c1d65: 8337980: Javac allows invocation of an inherited instance method from a static method
950e3a7: 8341625: Improve ZipFile validation of the END header
e704c05: 8340547: Starting many threads can delay safepoints
c30ad01: 8325495: C2: implement optimization for series of Add of unique value
ff2f39f: 8340214: C2 compilation asserts with "no node with a side effect" in PhaseIdealLoop::try_sink_out_of_loop
ecc77a5: 8336702: C2 compilation fails with "all memory state should have been processed" assert
d936556: 8341633: StatSampler::assert_system_property: Print the keys and values of the assert
3fba170: 8340786: Introduce Predicate classes with predicate iterators and visitors for simplified walking
047c2d7: 8341141: Optimize DirectCodeBuilder
d636e0d: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
... and 608 more: https://git.openjdk.org/jdk/compare/ea3370982bfd3da4b200b738dd3b8c16cebb3a34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-08-23T04:00:49Z

@sendaoYan The following label will be automatically applied to this pull request:

nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-08-23T04:03:41Z

Webrevs

sendaoYan · 2024-08-23T06:14:44Z

/issue JDK-8338884

openjdk · 2024-08-23T06:16:06Z

@sendaoYan This issue is referenced in the PR title - it will now be updated.

bplb · 2024-08-23T15:50:05Z

What happens in the test without this change if the fix for JDK-8338696 is applied?

sendaoYan · 2024-08-23T16:24:08Z

As descript in JDK-8338884, this test will report fails java.lang.RuntimeException: Creation time should not have changed without this change.
On alinux3(alibaba cloud system v3) the /tmp disk partition is mounted as tmpfs filesystem, and linux doesn't support birth time with this type filesystem.
Without this change before the fix JDK-8338696 is applied, then the creation time is set to the epoch (1970-01-01T00:00:00Z) so this test will throw SkippedException.
Without this change after the fix JDK-8338696 is applied, the SkippedException do not throw any more, and the supportsCreationTimeRead set to true, actually on alinux3 the file in /tmp partition doesn't support create time(birth time), and create time always equals to modified time, then this test report fails.

bplb · 2024-08-23T16:28:53Z

Without this change after the fix JDK-8338696 is applied, the SkippedException do not throw any more, and the supportsCreationTimeRead set to true, actually on alinux3 the file in /tmp partition doesn't support create time(birth time), and create time always equals to modified time, then this test report fails.

So you are saying that with the fix for JDK-8338696 applied, this test fails with RuntimeException?

sendaoYan · 2024-08-23T16:46:42Z

So you are saying that with the fix for JDK-8338696 applied, this test fails with RuntimeException?

Yes, without this change, with the fix for JDK-8338696 applied, this test fails with RuntimeException

sendaoYan · 2024-08-23T16:51:26Z

To reproduce the fails, test command on most linux system:

rm -rf /dev/shm/tmp/ ; jtreg -v:fail,error -w /dev/shm/tmp -nr test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#cwd

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

… and !Files.getFileStore(file).type().contentEquals("tmpfs")

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

…me or not", and set nfs not suoport create time

…Reader;

sendaoYan · 2024-08-26T15:13:43Z

nfs on linux also doesn't support create time:

> mount | grep "/vmfarm "
pepsi.jvm.alibaba.net:/vmfarm on /vmfarm type nfs4 (rw,relatime,vers=4.1,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=11.165.41.2,local_lock=none,addr=11.158.137.189)
> stat /vmfarm/mountVmFarm.sh 
  File: ‘/vmfarm/mountVmFarm.sh’
  Size: 71              Blocks: 8          IO Block: 1048576 regular file
Device: 3ch/60d Inode: 12          Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2024-02-28 17:03:54.713251462 +0800
Modify: 2020-03-03 11:56:41.548038922 +0800
Change: 2020-03-03 11:56:41.548038922 +0800
 Birth: -

sendaoYan · 2024-09-03T02:14:45Z

On RHEL 8 tmpfs doesn't seem to support birth time, but on F39 tmpfs does seem to support birth time. Looks like this might be related to the kernel version. It's difficult to enumerate all the combination of file system type and linux kernel version to determine the testd file support birth time or not. So in this PR, I get the output from stat -c linux command, to determine the testd file support birth ot not.

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c

sendaoYan · 2024-09-03T16:26:10Z

I think this PR should be set as draft status, sorry for that.

bplb · 2024-09-12T20:52:13Z

For whatever it shows, the test passed on Linux, macOS, and Windows in our CI.

jerboaa · 2024-09-13T09:29:05Z

For whatever it shows, the test passed on Linux, macOS, and Windows in our CI.

@bplb Do you mean the updated one in this PR or the old one without this patch?

bplb · 2024-09-13T15:42:43Z

For whatever it shows, the test passed on Linux, macOS, and Windows in our CI.

@bplb Do you mean the updated one in this PR or the old one without this patch?

@jerboaa The latest version in this PR.

jerboaa · 2024-09-13T16:08:26Z

For whatever it shows, the test passed on Linux, macOS, and Windows in our CI.

@bplb Do you mean the updated one in this PR or the old one without this patch?

@jerboaa The latest version in this PR.

OK, thanks!

sendaoYan · 2024-09-14T01:44:48Z

For whatever it shows, the test passed on Linux, macOS, and Windows in our CI.
@jerboaa The latest version in this PR.

Thanks for the test.

sendaoYan · 2024-10-07T15:18:37Z

@AlanBateman Can you review this again, thanks.

AlanBateman · 2024-10-07T16:00:02Z

@AlanBateman Can you review this again, thanks.

I don't have cycles right now but I'm sure @bplb can help.

bplb · 2024-10-07T16:02:26Z

I don't have cycles right now but I'm sure @bplb can help.

It's now in my queue.

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c

bplb · 2024-10-08T18:41:31Z

The test passed on Linux, macOS, and Windows in our internal test platform. I think after the two most recent points mentioned above are addressed it is good to go.

…ttributeView/libCreationTimeHelper.c; 2. use System.err instead of System.out in test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

sendaoYan · 2024-10-09T01:23:56Z

The test passed on Linux, macOS, and Windows in our internal test platform. I think after the two most recent points mentioned above are addressed it is good to go.

Thanks for the verify and review. The two advices has been addressed.

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

…st/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

bplb

Looks all right now.

sendaoYan · 2024-10-10T01:03:08Z

Thanks all for the review.
/integrate

openjdk · 2024-10-10T01:04:08Z

Going to push as commit 9d621d3.
Since your change was applied there have been 630 commits pushed to the master branch:

475f8f9: 8341859: Optimize ClassFile Benchmark Write
c850ecb: 8341755: Optimize argNames in InnerClassLambdaMetafactory
172f744: 8340985: Open source some Desktop related tests
e7045e9: 8341684: Typo in External Specifications link of java.util.Currency
49c7148: 8341366: Suspicious check in Locale.getDisplayName(Locale inLocale)
52eded4: 8341170: Open source several Choice related tests (part 2)
a45abf1: 8341860: ProblemList applications/ctw/modules/java_base_2.java on linux-x64
593c27e: 8341535: sun/awt/font/TestDevTransform.java fails with RuntimeException: Different rendering
3180aaa: 8341832: Incorrect continuation address of synthetic SIGSEGV for APX in product builds
3ab519f: 8341424: GHA: Collect hs_errs from build time failures
... and 620 more: https://git.openjdk.org/jdk/compare/ea3370982bfd3da4b200b738dd3b8c16cebb3a34...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-10T01:04:16Z

@sendaoYan Pushed as commit 9d621d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8338884: Test BasicFileAttributeView/CreationTime.java#tmp fails on a…

128e686

…linux3 after JDK-8338696

openjdk bot added the rfr Pull request is ready for review label Aug 23, 2024

openjdk bot added the nio nio-dev@openjdk.org label Aug 23, 2024

openjdk bot changed the title ~~8338884: Test BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 after JDK-8338696~~ 8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 Aug 23, 2024

bplb reviewed Aug 23, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java Outdated Show resolved Hide resolved

merge Linker.nativeLinker().defaultLookup().find("statx").isPresent()…

25694d7

… and !Files.getFileStore(file).type().contentEquals("tmpfs")

jerboaa reviewed Aug 26, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java Outdated Show resolved Hide resolved

use stat -c linux command line to determise support create time or not

1614f8e

AlanBateman reviewed Aug 26, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java Outdated Show resolved Hide resolved

sendaoYan added 2 commits August 26, 2024 21:10

revert "use stat -c linux command line to determise support create ti…

5ed7b8c

…me or not", and set nfs not suoport create time

delete import java.io.BufferedReader; and -import java.io.InputStream…

4dcdf24

…Reader;

sendaoYan requested a review from AlanBateman August 26, 2024 13:25

use stat -c linux command line to determise support create time or not

fe3fbc1

AlanBateman reviewed Sep 3, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java Outdated Show resolved Hide resolved

use jni to determine the tested file support birth time or not

78fbf83

jerboaa suggested changes Sep 3, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c Outdated Show resolved Hide resolved

jerboaa mentioned this pull request Oct 1, 2024

8341282: (fs) Move creation time fallback logic to Java layer (Linux) #21274

Closed

3 tasks

bplb reviewed Oct 8, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java Outdated Show resolved Hide resolved

bplb reviewed Oct 8, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/libCreationTimeHelper.c Outdated Show resolved Hide resolved

1. delete #DEBUG block in test/jdk/java/nio/file/attribute/BasicFileA…

6d4eb11

…ttributeView/libCreationTimeHelper.c; 2. use System.err instead of System.out in test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

bplb reviewed Oct 9, 2024

View reviewed changes

test/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java Outdated Show resolved Hide resolved

Use System.err.println instead of System.out.println in line 80 of te…

a086f88

…st/jdk/java/nio/file/attribute/BasicFileAttributeView/CreationTime.java

bplb approved these changes Oct 9, 2024

View reviewed changes

sendaoYan requested a review from jerboaa October 9, 2024 15:49

jerboaa approved these changes Oct 9, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Oct 9, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 10, 2024

openjdk bot closed this Oct 10, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 10, 2024

sendaoYan deleted the jbs8338884 branch October 10, 2024 01:05

sendaoYan restored the jbs8338884 branch October 10, 2024 01:05

sendaoYan mentioned this pull request Oct 11, 2024

8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #21462

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #20687

8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #20687

sendaoYan commented Aug 23, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Aug 23, 2024

openjdk bot commented Aug 23, 2024 •

edited

Loading

openjdk bot commented Aug 23, 2024

mlbridge bot commented Aug 23, 2024 •

edited

Loading

sendaoYan commented Aug 23, 2024

openjdk bot commented Aug 23, 2024

bplb commented Aug 23, 2024

sendaoYan commented Aug 23, 2024 •

edited

Loading

bplb commented Aug 23, 2024

sendaoYan commented Aug 23, 2024 •

edited

Loading

sendaoYan commented Aug 23, 2024

sendaoYan commented Aug 26, 2024

sendaoYan commented Sep 3, 2024

sendaoYan commented Sep 3, 2024

bplb commented Sep 12, 2024

jerboaa commented Sep 13, 2024

bplb commented Sep 13, 2024

jerboaa commented Sep 13, 2024

sendaoYan commented Sep 14, 2024

sendaoYan commented Oct 7, 2024

AlanBateman commented Oct 7, 2024

bplb commented Oct 7, 2024

bplb commented Oct 8, 2024

sendaoYan commented Oct 9, 2024

bplb left a comment

sendaoYan commented Oct 10, 2024

openjdk bot commented Oct 10, 2024

openjdk bot commented Oct 10, 2024

8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #20687

8338884: java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #20687

Conversation

sendaoYan commented Aug 23, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Aug 23, 2024

openjdk bot commented Aug 23, 2024 • edited Loading

openjdk bot commented Aug 23, 2024

mlbridge bot commented Aug 23, 2024 • edited Loading

Webrevs

sendaoYan commented Aug 23, 2024

openjdk bot commented Aug 23, 2024

bplb commented Aug 23, 2024

sendaoYan commented Aug 23, 2024 • edited Loading

bplb commented Aug 23, 2024

sendaoYan commented Aug 23, 2024 • edited Loading

sendaoYan commented Aug 23, 2024

sendaoYan commented Aug 26, 2024

sendaoYan commented Sep 3, 2024

sendaoYan commented Sep 3, 2024

bplb commented Sep 12, 2024

jerboaa commented Sep 13, 2024

bplb commented Sep 13, 2024

jerboaa commented Sep 13, 2024

sendaoYan commented Sep 14, 2024

sendaoYan commented Oct 7, 2024

AlanBateman commented Oct 7, 2024

bplb commented Oct 7, 2024

bplb commented Oct 8, 2024

sendaoYan commented Oct 9, 2024

bplb left a comment

Choose a reason for hiding this comment

sendaoYan commented Oct 10, 2024

openjdk bot commented Oct 10, 2024

openjdk bot commented Oct 10, 2024

sendaoYan commented Aug 23, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Aug 23, 2024 •

edited

Loading

mlbridge bot commented Aug 23, 2024 •

edited

Loading

sendaoYan commented Aug 23, 2024 •

edited

Loading

sendaoYan commented Aug 23, 2024 •

edited

Loading