8338882: Clarify matching order of MessageFormat subformat factory styles

[justin-curtis-lu]

Please review this PR which clarifies that the matching order of format styles for MessageFormat sub formats is not guaranteed. A corresponding CSR has also been drafted.

This is relevant when a locale provides equivalent patterns for multiple format factory styles. For example, a locale X could provide some equivalent date style "xyz" for both a MEDIUM and LONG style. Thus invoking toPattern() could output date, date,medium, or date,long depending on the order of such matching.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8338921 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8338882: Clarify matching order of MessageFormat subformat factory styles (Bug - P4)
• JDK-8338921: Clarify matching order of MessageFormat subformat factory styles (CSR)

Reviewers

• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20695/head:pull/20695
$ git checkout pull/20695

Update a local copy of the PR:
$ git checkout pull/20695
$ git pull https://git.openjdk.org/jdk.git pull/20695/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20695

View PR using the GUI difftool:
$ git pr show -t 20695

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20695.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338882: Clarify matching order of MessageFormat subformat factory styles

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 122 new commits pushed to the master branch:

• a528c4b: 8339156: Use more fine-granular clang unused warnings
• 2fb8305: 8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java
• 3a352b8: 8339191: JFR: Bulk read support for ChunkInputStream
• 92c4704: 8339166: java/lang/String/concat/HiddenClassUnloading.java fails on AIX and Linux ppc64le after JDK-8336856
• 2abe2ff: 8339235: Fix indentation in build system
• bb28b0d: 8338404: Cross-compilation to different endianness fails after JDK-8318913
• b872718: 8338301: Error recovery and reporting should be improved for erroneous implicitly declared classes
• b9e65f9: 8337662: Improve os::print_hex_dump for printing Instructions sections
• f927c12: 8339154: Cleanups and JUnit conversion of test/jdk/java/util/zip/Available.java
• 4675913: 8339237: RISC-V: Builds fail after JDK-8339120
• ... and 112 more: https://git.openjdk.org/jdk/compare/55851a312baaea5af14c04fb1b436313fe0deac7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@justin-curtis-lu The following labels will be automatically applied to this pull request:

• core-libs
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (8d434f29)
• 00: Full (7953073b)

[naotoj]

LGTM

[justin-curtis-lu]

/integrate

[openjdk]

Going to push as commit b840b13.
Since your change was applied there have been 124 commits pushed to the master branch:

• 25e03b5: 8339115: Rename TypeKind enum constants to follow code style
• fef1ef7: 6426678: (spec) File.createTempFile(prefix, suffix, dir) needs clarification for illegal symbols in suffix
• a528c4b: 8339156: Use more fine-granular clang unused warnings
• 2fb8305: 8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java
• 3a352b8: 8339191: JFR: Bulk read support for ChunkInputStream
• 92c4704: 8339166: java/lang/String/concat/HiddenClassUnloading.java fails on AIX and Linux ppc64le after JDK-8336856
• 2abe2ff: 8339235: Fix indentation in build system
• bb28b0d: 8338404: Cross-compilation to different endianness fails after JDK-8318913
• b872718: 8338301: Error recovery and reporting should be improved for erroneous implicitly declared classes
• b9e65f9: 8337662: Improve os::print_hex_dump for printing Instructions sections
• ... and 114 more: https://git.openjdk.org/jdk/compare/55851a312baaea5af14c04fb1b436313fe0deac7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@justin-curtis-lu Pushed as commit b840b13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.