8339112: Move JVM Klass flags out of AccessFlags

[coleenp]

Move JVM implementation access flags that are not specified by the classfile format into Klass so we can shrink AccessFlags to u2 in a future change.

Tested with tier1-7.

NOTE: there are arm, ppc and s390 changes to this that are just a guess. Also, graal changes.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339112: Move JVM Klass flags out of AccessFlags (Enhancement - P4)

Reviewers

• Matias Saavedra Silva (@matias9927 - Reviewer)
• Chris Plummer (@plummercj - Reviewer) Review applies to 9dc7e551
• Dean Long (@dean-long - Reviewer) Review applies to 4c3a04dc
• Tobias Hartmann (@TobiHartmann - Reviewer) Review applies to 4c3a04dc
• Yudi Zheng (@mur47x111 - Committer) Review applies to 4c3a04dc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20719/head:pull/20719
$ git checkout pull/20719

Update a local copy of the PR:
$ git checkout pull/20719
$ git pull https://git.openjdk.org/jdk.git pull/20719/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20719

View PR using the GUI difftool:
$ git pr show -t 20719

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20719.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339112: Move JVM Klass flags out of AccessFlags

Reviewed-by: matsaave, cjplummer, dlong, thartmann, yzheng

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

• 6f8714e: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long
• c7d15f1: 8325679: Optimize ArrayList subList sort
• bd8569b: 8339131: Remove rarely-used accessor methods from Opcode
• e25a9e7: 8339486: JFR: Modernize
• 4e2dde2: 8339371: jlink.log warning when building after JDK-8338404
• 7ad6160: 8339163: ZGC: Race in clearing of remembered sets
• a618605: 8339399: ZGC: Remove unnecessary page reset when splitting pages
• f2c992c: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
• 9a1024d: 8190329: [macos] Swing InterOp Platform.exit() crash
• 5998f4b: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can be removed
• ... and 123 more: https://git.openjdk.org/jdk/compare/6cf7f9c4a76b99ed7aa4dc7ee54692331fc73408...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following labels will be automatically applied to this pull request:

• graal
• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (79c35f7c)
• 04: Full - Incremental (4c3a04dc)
• 03: Full - Incremental (9e93b2a5)
• 02: Full - Incremental (852ca049)
• 01: Full - Incremental (9dc7e551)
• 00: Full (350f8679)

[matias9927]

x86 and ARM interpreter code looks good, just one potential nit.

[coleenp]

Dean and Matias, thank you for the improvements to the assembly code. Dean I took your suggestions, including refactoring C2 code. Thanks for the thorough look at this change.

[matias9927]

Interpreter changes look good, thanks!

[coleenp]

Thanks Chris and Matias for reviewing parts of this.

[offamitkumar]

Hi @coleenp,

I got this error while build on my Mac-M1, did you see something like this ? :

ERROR: Failed to generate link optimization data. This is likely a problem with the newly built JVM/JDK.
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error (/Users/amitkumar/jdk/src/hotspot/share/oops/klassFlags.hpp:72), pid=57968, tid=10499
#  assert(!is_value_based_class()) failed: set once
#
# JRE version:  (24.0) (fastdebug build )
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 24-internal-adhoc.amitkumar.jdk, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, bsd-aarch64)
# No core dump will be written. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /Users/amitkumar/jdk/make/hs_err_pid57968.log
#
#

These are the changes with which I am build the JVM. I can reproduce it on my s390x-machine as well.

diff --git a/src/hotspot/share/runtime/globals.hpp b/src/hotspot/share/runtime/globals.hpp
index d442894798b..fbd1a2b3281 100644
--- a/src/hotspot/share/runtime/globals.hpp
+++ b/src/hotspot/share/runtime/globals.hpp
@@ -170,7 +170,7 @@ const int ObjectAlignmentInBytes = 8;
   product(bool, AlwaysSafeConstructors, false, EXPERIMENTAL,                \
           "Force safe construction, as if all fields are final.")           \
                                                                             \
-  product(bool, UnlockDiagnosticVMOptions, trueInDebug, DIAGNOSTIC,         \
+  product(bool, UnlockDiagnosticVMOptions, true, DIAGNOSTIC,         \
           "Enable normal processing of flags relating to field diagnostics")\
                                                                             \
   product(bool, UnlockExperimentalVMOptions, false, EXPERIMENTAL,           \
@@ -819,7 +819,7 @@ const int ObjectAlignmentInBytes = 8;
   product(bool, RestrictContended, true,                                    \
           "Restrict @Contended to trusted classes")                         \
                                                                             \
-  product(int, DiagnoseSyncOnValueBasedClasses, 0, DIAGNOSTIC,              \
+  product(int, DiagnoseSyncOnValueBasedClasses, 1, DIAGNOSTIC,              \
              "Detect and take action upon identifying synchronization on "  \
              "value based classes. Modes: "                                 \
              "0: off; "                                                     \

[TobiHartmann]

The JIT changes look good to me.

[mur47x111]

JVMCI changes look good to me!

[coleenp]

@offamitkumar Thank you for finding this bug. These flags have asserts that they're only set once, but CDS restores sets the value for this flag. Since it was set when dumping the archive, it resets it, which is okay in this case. I have a fix for this.

[matias9927]

Updates look good!

[coleenp]

Thank you for reviewing, Dean, Tobias, Amit, Exe-Boss and reviewing the updates also Matias.
/integrate

[openjdk]

Going to push as commit 0cfd08f.
Since your change was applied there have been 133 commits pushed to the master branch:

• 6f8714e: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long
• c7d15f1: 8325679: Optimize ArrayList subList sort
• bd8569b: 8339131: Remove rarely-used accessor methods from Opcode
• e25a9e7: 8339486: JFR: Modernize
• 4e2dde2: 8339371: jlink.log warning when building after JDK-8338404
• 7ad6160: 8339163: ZGC: Race in clearing of remembered sets
• a618605: 8339399: ZGC: Remove unnecessary page reset when splitting pages
• f2c992c: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
• 9a1024d: 8190329: [macos] Swing InterOp Platform.exit() crash
• 5998f4b: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can be removed
• ... and 123 more: https://git.openjdk.org/jdk/compare/6cf7f9c4a76b99ed7aa4dc7ee54692331fc73408...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 0cfd08f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.