Skip to content

8339112: Move JVM Klass flags out of AccessFlags #20719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed

8339112: Move JVM Klass flags out of AccessFlags #20719

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6d73884
Move JVM_ACC_IS_HIDDEN_CLASS.
coleenp Aug 23, 2024
18fcef0
Move JVM_ACC_IS_VALUE_BASED_CLASS.
coleenp Aug 23, 2024
6075602
Refix is_hidden_class to use misc_flags.
coleenp Aug 26, 2024
47a5000
Add in has_finalizer and is_cloneable_fast but doesn't work for C2 yet.
coleenp Aug 26, 2024
ccefd4e
Fix typeo.
coleenp Aug 26, 2024
bb6491a
Fix C2 things I hope.
coleenp Aug 27, 2024
c6a278b
The test compiler/types/TestSubTypeCheckNewObjectNotConstant.java ass…
coleenp Aug 27, 2024
1bbd30c
Fix s390 compilation errors.
coleenp Aug 28, 2024
350f867
Fix C1 nodes for misc_flags access.
coleenp Aug 28, 2024
9dc7e55
Add in graal flags and a comment.
coleenp Aug 29, 2024
6754f42
Assembly corrections from Matias and Dean.
coleenp Aug 30, 2024
ad7deac
Some C2 refactoring.
coleenp Aug 30, 2024
852ca04
Fix jvmci code.
coleenp Aug 30, 2024
9e93b2a
Refactor jvmci code.
coleenp Aug 30, 2024
4c3a04d
Add parameters and rename generate_klass_flags_guard.
coleenp Aug 30, 2024
9f91857
Add parameters and rename generate_klass_flags_guard.
coleenp Sep 3, 2024
79c35f7
Remove unused function declaration.
coleenp Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotResolvedObjectTypeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,11 @@ public int getAccessFlags() {
return UNSAFE.getInt(getKlassPointer() + config.klassAccessFlagsOffset);
}

public int getMiscFlags() {
HotSpotVMConfig config = config();
return UNSAFE.getInt(getKlassPointer() + config.klassMiscFlagsOffset);
}

@Override
public ResolvedJavaType getComponentType() {
if (componentType == null) {
Expand Down Expand Up @@ -373,8 +378,7 @@ public AssumptionResult<Boolean> hasFinalizableSubclass() {

@Override
public boolean hasFinalizer() {
int miscFlags = UNSAFE.getByte(getKlassPointer() + config().klassMiscFlagsOffset);
return (miscFlags & config().jvmAccHasFinalizer) != 0;
return (getMiscFlags() & config().jvmAccHasFinalizer) != 0;
}

@Override
Expand Down Expand Up @@ -1111,8 +1115,7 @@ public ResolvedJavaField resolveField(UnresolvedJavaField unresolvedJavaField, R

@Override
public boolean isCloneableWithAllocation() {
int miscFlags = UNSAFE.getByte(getKlassPointer() + config().klassMiscFlagsOffset);
return (miscFlags & config().jvmAccIsCloneableFast) != 0;
return (getMiscFlags() & config().jvmAccIsCloneableFast) != 0;
}

@Override
Expand Down