8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation

[fguallini]

The test sun/security/validator/samedn.sh failed once due to the following reason:

Caused by: java.security.cert.CertificateNotYetValidException: NotBefore: Tue Aug 06 14:41:13 GMT 2024

This test generates several certificates using the keytool as a precondition, and then validates their certificate paths.

This failure is very rare and could not be reproduced. However, based on the failure logs, the test finished at 14:41:12, while the test certificate's NotBefore time was set to 14:41:13. It is possible that when the certificate was created, keytool rounded up the NotBefore time to the nearest second. As a result, the test may have validated the certificate just before it became valid.

The proposed fix is to set the NotBefore time to one minute in the past, ensuring the certificate will be valid when running the test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation (Bug - P3)

Reviewers

• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20728/head:pull/20728
$ git checkout pull/20728

Update a local copy of the PR:
$ git checkout pull/20728
$ git pull https://git.openjdk.org/jdk.git pull/20728/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20728

View PR using the GUI difftool:
$ git pr show -t 20728

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20728.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337951: Test sun/security/validator/samedn.sh CertificateNotYetValidException: NotBefore validation

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 94 new commits pushed to the master branch:

• 7a418fc: 8338967: Improve performance for MemorySegment::fill
• 633fad8: 8326615: C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash)
• 6f3e3fd: 8339411: [PPC64] cmpxchgw/h/b doesn't handle external Label
• ed422ed: 8338817: Wrong indent in API docs for java.lang.management.ManagementFactory
• 288fa60: 8338891: HotSpotDiagnosticsMXBean missing @SInCE tag
• dc4fd89: 8339359: RISC-V: Use auipc explicitly in far_jump and far_call macro assembler routines
• 3a88fd4: 8334724: C2: remove PhaseIdealLoop::cast_incr_before_loop()
• 62dad3a: 8339351: Remove duplicate line in FileMapHeader::print
• 0e6bb51: 8339063: [aarch64] Skip verify_sve_vector_length after native calls if SVE supports 128 bits VL only
• b1163bc: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)
• ... and 84 more: https://git.openjdk.org/jdk/compare/916f1aa04f6fcc6da9bf9d725e3639cf4c0755a1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fguallini The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9b43850b)

[fguallini]

/integrate

[openjdk]

@fguallini
Your change (at version 9b43850) is now ready to be sponsored by a Committer.

[seanjmullan]

/sponsor

[openjdk]

Going to push as commit a505a1d.
Since your change was applied there have been 134 commits pushed to the master branch:

• 6be9272: 8338591: Improve performance of MemorySegment::copy
• cb9f5c5: 8339290: Optimize ClassFile Utf8EntryImpl#writeTo
• 340e131: 8338971: IGV: Add incrementally inlined method name to phase name
• 2305d18: 8339384: Unintentional IOException in jdk.jdi module when JDWP end of stream occurs
• 96a0502: 8339369: G1: TestVerificationInConcurrentCycle.java fails with "Missing rem set entry" when using "-XX:G1RSetUpdatingPauseTimePercent=0 -XX:G1UpdateBufferSize=2"
• 28de44d: 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'
• 96df5a6: 8339316: Test runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java fails after JDK-8338257
• 55312e1: 8338937: Optimize the string concatenation of ClassDesc
• d4dfa01: 8338530: CDS warning Skipping java/lang/invoke/BoundMethodHandle$Species_LLLL
• b8d560b: 8339233: Test javax/swing/JButton/SwingButtonResizeTestWithOpenGL.java#id failed: Button renderings are different after window resize
• ... and 124 more: https://git.openjdk.org/jdk/compare/916f1aa04f6fcc6da9bf9d725e3639cf4c0755a1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@seanjmullan @fguallini Pushed as commit a505a1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.