8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 #20732

matias9927 · 2024-08-27T18:01:16Z

The change in JDK-8335664 caused a crash when initializing basic blocks with -Xcomp. This change introduces a check to see if JSR is the last bytecode in its method so that expected behavior matches the previous patch. Verified with tier 1-6 tests.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 (Bug - P4)

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer)
Tobias Hartmann (@TobiHartmann - Reviewer)

Contributors

Dean Long <dlong@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20732/head:pull/20732
$ git checkout pull/20732

Update a local copy of the PR:
$ git checkout pull/20732
$ git pull https://git.openjdk.org/jdk.git pull/20732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20732

View PR using the GUI difftool:
$ git pr show -t 20732

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20732.diff

Webrev

Link to Webrev Comment

…i < _len) failed: illegal index 5 for length 5

bridgekeeper · 2024-08-27T18:01:58Z

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-08-27T18:02:11Z

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5

Co-authored-by: Dean Long <dlong@openjdk.org>
Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 61 new commits pushed to the master branch:

433f6d8: 8339492: StackMapDecoder::writeFrames makes lots of allocations
ef96a7b: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS
12d060a: 8339148: Make os::Linux::active_processor_count() public
0cfd08f: 8339112: Move JVM Klass flags out of AccessFlags
6f8714e: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long
c7d15f1: 8325679: Optimize ArrayList subList sort
bd8569b: 8339131: Remove rarely-used accessor methods from Opcode
e25a9e7: 8339486: JFR: Modernize
4e2dde2: 8339371: jlink.log warning when building after JDK-8338404
7ad6160: 8339163: ZGC: Race in clearing of remembered sets
... and 51 more: https://git.openjdk.org/jdk/compare/777ed2b5d2ef8371407cc9bf0370a7cef937cfb7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-08-27T18:02:38Z

@matias9927 The following label will be automatically applied to this pull request:

hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

dean-long · 2024-08-29T00:16:38Z

Please add a loop to the test so it triggers this issue without -Xcomp.

mlbridge · 2024-08-29T17:20:27Z

Webrevs

coleenp

Just a comment.

coleenp · 2024-08-30T17:28:16Z

test/hotspot/jtreg/runtime/interpreter/LastJsrTest.java

 */

 public class LastJsrTest {
    public static void main(String[] args) {
-        LastJsr.test();
-        LastJsrReachable.test();
+        for (int i = 0; i < 1000; ++i) {


Don't you need 10,000 in your loop to trigger compilation?

Yes for C2, but this is enough for C1, the only compiler that needs this fix. I wanted to make sure C1 compilation was triggered by default without -Xcomp. Testing tiers that use -Xcomp will make sure it passes with C2.

matias9927 · 2024-08-30T17:58:25Z

/contributor add @dean-long

openjdk · 2024-08-30T17:59:15Z

@matias9927
Contributor Dean Long <dlong@openjdk.org> successfully added.

vnkozlov · 2024-08-31T00:20:54Z

test/hotspot/jtreg/runtime/interpreter/LastJsrTest.java

- * @run main/othervm LastJsrTest
+ * @run main/othervm
+ *      -Xbatch
+ *      LastJsrTest


I suggest to keep old command too.
And I don't like spliting new command into several lines when it is very short.

vnkozlov · 2024-08-31T00:22:53Z

src/hotspot/share/compiler/methodLiveness.cpp

+
+          if (bci + Bytecodes::length_for(code) >= method_len) break;
+


Please, use code style which use {} and put body on separate line as you did in c1_GraphBuilder.cpp
You will not need empty lines around it then.

vnkozlov · 2024-08-31T00:23:53Z

src/hotspot/share/compiler/methodLiveness.cpp

+
+          if (bci + Bytecodes::length_for(code) >= method_len) break;
+


TobiHartmann · 2024-09-03T09:07:31Z

test/hotspot/jtreg/runtime/interpreter/LastJsrTest.java

@@ -24,17 +24,22 @@
 /*
 * @test
 * @bug 8335664
+ * @bug 8338924


Drive-by comment: You can use @bug 8335664 8338924 instead.

vnkozlov

Good.

TobiHartmann · 2024-09-04T05:58:35Z

src/hotspot/share/c1/c1_GraphBuilder.cpp

@@ -1389,6 +1389,11 @@ void GraphBuilder::jsr(int dest) {
  // If the bytecodes are strange (jumping out of a jsr block) then we
  // might end up trying to re-parse a block containing a jsr which
  // has already been activated. Watch for this case and bail out.
+  if (next_bci() >= method()->code_size()) {
+      // This can happen if the subroutine does not terminate with a ret,


Indentation is incorrect here (should be 2 whitespace instead of 4).

TobiHartmann

Looks good to me otherwise.

vnkozlov

Update is good.

TobiHartmann

Still good.

matias9927 · 2024-09-04T17:24:26Z

Thanks for the reviews @TobiHartmann and @vnkozlov! Also thank you for the assistance @dean-long!
/integrate

openjdk · 2024-09-04T17:25:39Z

Going to push as commit 1353601.
Since your change was applied there have been 61 commits pushed to the master branch:

433f6d8: 8339492: StackMapDecoder::writeFrames makes lots of allocations
ef96a7b: 8332901: Select{Current,New}ItemTest.java for Choice don't open popup on macOS
12d060a: 8339148: Make os::Linux::active_processor_count() public
0cfd08f: 8339112: Move JVM Klass flags out of AccessFlags
6f8714e: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long
c7d15f1: 8325679: Optimize ArrayList subList sort
bd8569b: 8339131: Remove rarely-used accessor methods from Opcode
e25a9e7: 8339486: JFR: Modernize
4e2dde2: 8339371: jlink.log warning when building after JDK-8338404
7ad6160: 8339163: ZGC: Race in clearing of remembered sets
... and 51 more: https://git.openjdk.org/jdk/compare/777ed2b5d2ef8371407cc9bf0370a7cef937cfb7...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-09-04T17:25:46Z

@matias9927 Pushed as commit 1353601.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

matias9927 added 4 commits August 26, 2024 16:35

8338924: runtime/interpreter/LastJsrTest.java fails assert(0 <= i && …

e5bbe77

…i < _len) failed: illegal index 5 for length 5

Removed repeated code

b7e6deb

Merge branch 'master' into jsr_test_8338924

65fd622

Corrected previous change

e87cd03

Removed test from problem list

2ca2a29

openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 27, 2024

Moved conditional up

57bf6f0

matias9927 changed the title ~~8338924: runtime/interpreter/LastJsrTest.java fails assert(0 <= i && i < _len) failed: illegal index 5 for length 5~~ 8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 Aug 29, 2024

matias9927 added 4 commits August 29, 2024 15:15

Dean patch

4b8617e

Merge branch 'master' into jsr_test_8338924

8db99f2

Removed from Problemlist-Xcomp

a14fa7c

Copyright date

511d520

matias9927 marked this pull request as ready for review August 29, 2024 17:16

openjdk bot added the rfr Pull request is ready for review label Aug 29, 2024

coleenp reviewed Aug 30, 2024

View reviewed changes

vnkozlov reviewed Aug 31, 2024

View reviewed changes

TobiHartmann reviewed Sep 3, 2024

View reviewed changes

Vladimir and Tobias comments

e324170

vnkozlov approved these changes Sep 3, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 3, 2024

TobiHartmann reviewed Sep 4, 2024

View reviewed changes

TobiHartmann approved these changes Sep 4, 2024

View reviewed changes

Fixed indentation

0a4d760

openjdk bot removed the ready Pull request is ready to be integrated label Sep 4, 2024

vnkozlov approved these changes Sep 4, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Sep 4, 2024

TobiHartmann approved these changes Sep 4, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Sep 4, 2024

openjdk bot closed this Sep 4, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 #20732

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 #20732

matias9927 commented Aug 27, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Aug 27, 2024

openjdk bot commented Aug 27, 2024 •

edited

Loading

openjdk bot commented Aug 27, 2024

dean-long commented Aug 29, 2024

mlbridge bot commented Aug 29, 2024 •

edited

Loading

coleenp left a comment

coleenp Aug 30, 2024

dean-long Aug 30, 2024

coleenp Sep 3, 2024

matias9927 commented Aug 30, 2024

openjdk bot commented Aug 30, 2024

vnkozlov Aug 31, 2024

vnkozlov Aug 31, 2024

vnkozlov Aug 31, 2024

TobiHartmann Sep 3, 2024

vnkozlov left a comment

TobiHartmann Sep 4, 2024

TobiHartmann left a comment

vnkozlov left a comment

TobiHartmann left a comment

matias9927 commented Sep 4, 2024

openjdk bot commented Sep 4, 2024

openjdk bot commented Sep 4, 2024

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 #20732

8338924: C1: assert(0 <= i && i < _len) failed: illegal index 5 for length 5 #20732

Conversation

matias9927 commented Aug 27, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Contributors

Reviewing

Webrev

bridgekeeper bot commented Aug 27, 2024

openjdk bot commented Aug 27, 2024 • edited Loading

openjdk bot commented Aug 27, 2024

dean-long commented Aug 29, 2024

mlbridge bot commented Aug 29, 2024 • edited Loading

Webrevs

coleenp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matias9927 commented Aug 30, 2024

openjdk bot commented Aug 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vnkozlov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TobiHartmann left a comment

Choose a reason for hiding this comment

vnkozlov left a comment

Choose a reason for hiding this comment

TobiHartmann left a comment

Choose a reason for hiding this comment

matias9927 commented Sep 4, 2024

openjdk bot commented Sep 4, 2024

openjdk bot commented Sep 4, 2024

matias9927 commented Aug 27, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Aug 27, 2024 •

edited

Loading

mlbridge bot commented Aug 29, 2024 •

edited

Loading