Skip to content

8339126: JNI exception pending in Inflater.c #20735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Aug 27, 2024

This PR addresses the JNI pending exception in Inflater.c, under Java_java_util_zip_Inflater_initIDs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339126: JNI exception pending in Inflater.c (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20735/head:pull/20735
$ git checkout pull/20735

Update a local copy of the PR:
$ git checkout pull/20735
$ git pull https://git.openjdk.org/jdk.git pull/20735/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20735

View PR using the GUI difftool:
$ git pr show -t 20735

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20735.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2024

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339126: JNI exception pending in Inflater.c

Reviewed-by: lancea, vtewari, jpai, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 379f3db: 8339175: ProblemList runtime/interpreter/LastJsrTest.java on all platforms with Xcomp
  • b670009: 8338729: Retire the test jdk/java/util/zip/TestZipError.java
  • 32c9750: 8339160: [BACKOUT] JDK-8338440 Parallel: Improve fragmentation mitigation in Full GC
  • 9d183bd: 8339149: jfr_flush_event_writer - return value type mismatch
  • 2150521: 8322036: Improve help output from the javadoc tool
  • 1ff9ac7: 8338731: MemoryLayout::offsetHandle can return a negative offset
  • 2e174c6: 8338445: jdk.internal.loader.URLClassPath may leak JarFile instance when dealing with unexpected Class-Path entry in manifest
  • 8e88da0: 8338041: Keyboard Navigation of JTable, Ctrl Shift RIGHT/LEFT doesn't follow native action in GTK L&F
  • 449ca2c: 8337832: Optimize datetime toString

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 27, 2024
@openjdk
Copy link

openjdk bot commented Aug 27, 2024

@justin-curtis-lu The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 27, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 27, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 28, 2024
Copy link
Contributor

@vyommani vyommani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

@justin-curtis-lu
Copy link
Member Author

Thank you all for the reviews.
/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

Going to push as commit a8ac287.
Since your change was applied there have been 15 commits pushed to the master branch:

  • d08b5bd: 8258483: [TESTBUG] gtest CollectorPolicy.young_scaled_initial_ergo_vm fails if heap is too small
  • d03ec7a: 8339030: frame::print_value_on(outputStream* st, JavaThread *thread) doesn't need thread argument
  • eff6d9c: 8339167: Remove AbstractPoolEntry.PrimitiveEntry to reduce boxing overheads
  • a98ecad: 8338897: Small startup regression remains after JDK-8309622 and JDK-8331932
  • 3d49fb8: 8338103: Stabilize and open source a Swing OGL ButtonResizeTest
  • 0c2b175: 8328608: Multiple NewSessionTicket support for TLS
  • 379f3db: 8339175: ProblemList runtime/interpreter/LastJsrTest.java on all platforms with Xcomp
  • b670009: 8338729: Retire the test jdk/java/util/zip/TestZipError.java
  • 32c9750: 8339160: [BACKOUT] JDK-8338440 Parallel: Improve fragmentation mitigation in Full GC
  • 9d183bd: 8339149: jfr_flush_event_writer - return value type mismatch
  • ... and 5 more: https://git.openjdk.org/jdk/compare/b1b4cd429a4135840966975dd0c068fe428e2ee6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2024
@openjdk openjdk bot closed this Aug 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@justin-curtis-lu Pushed as commit a8ac287.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants