Skip to content

8339169: Remove NaiveHuffman coder #20764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AlekseiEfimov
Copy link
Member

@AlekseiEfimov AlekseiEfimov commented Aug 29, 2024

jdk.internal.net.http.hpack.NaiveHuffman is an internal class and not used in java.net.http module or any test.
It is proposed to remove this class.
HttpClient will continue to use the jdk.internal.net.http.hpack.QuickHuffman to encode/decode string literals.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20764/head:pull/20764
$ git checkout pull/20764

Update a local copy of the PR:
$ git checkout pull/20764
$ git pull https://git.openjdk.org/jdk.git pull/20764/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20764

View PR using the GUI difftool:
$ git pr show -t 20764

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20764.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2024

👋 Welcome back aefimov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@AlekseiEfimov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339169: Remove NaiveHuffman coder

Reviewed-by: djelinski, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • e57b593: 8335062: NMT: Make StackIndex non-opaque
  • 8c8b580: 8338281: jshell does not run shutdown hooks
  • d35ffa4: 8339017: Make a couple of fields in DoubleByte static
  • 723588a: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started
  • 362f9ce: 8339120: Use more fine-granular gcc unused warnings
  • f080b4b: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero
  • ff59532: 8338678: Erroneous parameterized type represented as
  • 0b4a7d5: 8324859: Improve error recovery
  • 1383fec: 8327381: Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value
  • eb7ead5: 8336873: BasicSplitPaneDivider:oneTouchExpandableChanged() should mention that implementation depends on SplitPane.supportsOneTouchButtons property
  • ... and 12 more: https://git.openjdk.org/jdk/compare/32c975098521e830ce706b67e7232a007c0846c7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 29, 2024
@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@AlekseiEfimov The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Aug 29, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 29, 2024
@AlekseiEfimov
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

Going to push as commit 03ba37e.
Since your change was applied there have been 44 commits pushed to the master branch:

  • a136a85: 8338768: Introduce runtime lookup to check for static builds
  • 9d7d85a: 8339298: Remove unused function declaration poll_for_safepoint
  • 92aafb4: 8338934: vmTestbase/nsk/jvmti/FieldWatch/TestDescription.java tests timeout intermittently
  • 392bdd5: 8339248: RISC-V: Remove li64 macro assembler routine and related code
  • 4f071ce: 8311163: Parallel: Improve large object handling during evacuation
  • b840b13: 8338882: Clarify matching order of MessageFormat subformat factory styles
  • 25e03b5: 8339115: Rename TypeKind enum constants to follow code style
  • fef1ef7: 6426678: (spec) File.createTempFile(prefix, suffix, dir) needs clarification for illegal symbols in suffix
  • a528c4b: 8339156: Use more fine-granular clang unused warnings
  • 2fb8305: 8339319: ProblemList runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java
  • ... and 34 more: https://git.openjdk.org/jdk/compare/32c975098521e830ce706b67e7232a007c0846c7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 2, 2024
@openjdk openjdk bot closed this Sep 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@AlekseiEfimov Pushed as commit 03ba37e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants