Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Aug 29, 2024

Please review the change to update to using jtreg 7.5.1.

The primary change is to the jib-profiles.js file, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, the requiredVersion has been updated in the various TEST.ROOT files.

Tested with tier 1 — tier 8.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339238: Update to use jtreg 7.5.1 (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20766/head:pull/20766
$ git checkout pull/20766

Update a local copy of the PR:
$ git checkout pull/20766
$ git pull https://git.openjdk.org/jdk.git pull/20766/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20766

View PR using the GUI difftool:
$ git pr show -t 20766

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20766.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2024

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339238: Update to use jtreg 7.5.1

Reviewed-by: erikj, jpai, rriggs, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 234 new commits pushed to the master branch:

  • 04659a4: 8350197: [UBSAN] Node::dump_idx reported float-cast-overflow
  • 2d03bd0: 8350280: The JDK-8346050 testlibrary changes break the build
  • f2b4e12: 8350263: JvmciNotifyBootstrapFinishedEventTest intermittently times out
  • 46d4a60: 8349088: De-virtualize Codeblob and nmethod
  • 62d93f2: 8346050: Update BuildTestLib.gmk to build whole testlibrary
  • e1d0a9c: 8350202: Tune for Power10 CPUs on Linux ppc64le
  • 885be2e: 8349908: RISC-V: C2 SelectFromTwoVector
  • 8193e0d: 8346280: C2: implement late barrier elision for G1
  • d7baae3: 8350178: Incorrect comment after JDK-8345580
  • 160db5f: 8340110: Ubsan: verifier.cpp:2043:19: runtime error: shift exponent 100 is too large for 32-bit type 'int'
  • ... and 224 more: https://git.openjdk.org/jdk/compare/98a93e115137a305aed6b7dbf1d4a7d5906fe77c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@sormuras The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 29, 2024
@sormuras sormuras changed the title Update to use jtreg 7.5 8339238: Update to use jtreg 7.5 Aug 29, 2024
@sormuras sormuras force-pushed the 8339238-use-jtreg-7.5 branch from e126565 to d68b19f Compare September 10, 2024 06:02
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2024

@sormuras This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot changed the title 8339238: Update to use jtreg 7.5 8339238: Update to use jtreg 7.5.1 Nov 27, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2024

@sormuras This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 19, 2024
@sormuras
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Jan 27, 2025
@openjdk
Copy link

openjdk bot commented Jan 27, 2025

@sormuras This pull request is now open

@sormuras sormuras force-pushed the 8339238-use-jtreg-7.5 branch from 1e8fcc5 to 052a347 Compare January 27, 2025 13:57
@sormuras sormuras force-pushed the 8339238-use-jtreg-7.5 branch from 1a8d01c to c4c75c2 Compare January 29, 2025 06:48
@sormuras sormuras marked this pull request as ready for review February 11, 2025 14:48
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 11, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 11, 2025
@jaikiran
Copy link
Member

This looks good to me. Before integrating, it might be a good idea to also check with Roger if this jtreg release works fine against the project (valhalla?) where a previous jtreg release had shown some issues.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 14, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 14, 2025
@RogerRiggs
Copy link
Contributor

fyi, the Valhalla build works fine with jtreg 7.5.1 (and a few other updates to tests).

@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 19, 2025

Going to push as commit 9042aa8.
Since your change was applied there have been 235 commits pushed to the master branch:

  • 4de92a4: 8350224: Test javax/swing/JComboBox/TestComboBoxComponentRendering.java fails in ubuntu 23.x and later
  • 04659a4: 8350197: [UBSAN] Node::dump_idx reported float-cast-overflow
  • 2d03bd0: 8350280: The JDK-8346050 testlibrary changes break the build
  • f2b4e12: 8350263: JvmciNotifyBootstrapFinishedEventTest intermittently times out
  • 46d4a60: 8349088: De-virtualize Codeblob and nmethod
  • 62d93f2: 8346050: Update BuildTestLib.gmk to build whole testlibrary
  • e1d0a9c: 8350202: Tune for Power10 CPUs on Linux ppc64le
  • 885be2e: 8349908: RISC-V: C2 SelectFromTwoVector
  • 8193e0d: 8346280: C2: implement late barrier elision for G1
  • d7baae3: 8350178: Incorrect comment after JDK-8345580
  • ... and 225 more: https://git.openjdk.org/jdk/compare/98a93e115137a305aed6b7dbf1d4a7d5906fe77c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 19, 2025
@openjdk openjdk bot closed this Feb 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 19, 2025
@openjdk
Copy link

openjdk bot commented Feb 19, 2025

@sormuras Pushed as commit 9042aa8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the 8339238-use-jtreg-7.5 branch February 19, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants