-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8339238: Update to use jtreg 7.5.1 #20766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back cstein! A progress list of the required criteria for merging this PR into |
|
@sormuras This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 234 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
e126565 to
d68b19f
Compare
|
@sormuras This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@sormuras This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@sormuras This pull request is now open |
1e8fcc5 to
052a347
Compare
1a8d01c to
c4c75c2
Compare
Webrevs
|
|
This looks good to me. Before integrating, it might be a good idea to also check with Roger if this jtreg release works fine against the project (valhalla?) where a previous jtreg release had shown some issues. |
|
fyi, the Valhalla build works fine with jtreg 7.5.1 (and a few other updates to tests). |
|
/integrate |
|
Going to push as commit 9042aa8.
Your commit was automatically rebased without conflicts. |
Please review the change to update to using jtreg 7.5.1.
The primary change is to the
jib-profiles.jsfile, which specifies the version of jtreg to use, for those systems that rely on this file. In addition, therequiredVersionhas been updated in the variousTEST.ROOTfiles.Tested with tier 1 — tier 8.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20766/head:pull/20766$ git checkout pull/20766Update a local copy of the PR:
$ git checkout pull/20766$ git pull https://git.openjdk.org/jdk.git pull/20766/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20766View PR using the GUI difftool:
$ git pr show -t 20766Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20766.diff
Using Webrev
Link to Webrev Comment