Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259773: Incorrect encoding of AVX-512 kmovq instruction #2078

Closed
wants to merge 1 commit into from

Conversation

@jatin-bhateja
Copy link
Member

@jatin-bhateja jatin-bhateja commented Jan 14, 2021

While working on a prototype for supporting opmask register allocation encountered this bug.

Encoding for following instruction[1] which spills the value of an opmask register into memory should have 0x91 as the opcode instead of 0x90.

KMOVQ Address , K1.

[1] https://www.felixcloutier.com/x86/kmovw:kmovb:kmovq:kmovd


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259773: Incorrect encoding of AVX-512 kmovq instruction

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2078/head:pull/2078
$ git checkout pull/2078

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 14, 2021

👋 Welcome back jbhateja! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@jatin-bhateja
Copy link
Member Author

@jatin-bhateja jatin-bhateja commented Jan 14, 2021

/label hotspot-compiler-dev

Loading

@openjdk openjdk bot added the rfr label Jan 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@jatin-bhateja The label hotspot-compile is not a valid label. These labels are valid:

  • serviceability
  • hotspot
  • sound
  • hotspot-compiler
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • 2d
  • security
  • swing
  • hotspot-runtime
  • jmx
  • build
  • nio
  • beans
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr
  • awt

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@jatin-bhateja The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 14, 2021

Webrevs

Loading

Copy link

@iwanowww iwanowww left a comment

Looks good.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@jatin-bhateja This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259773: Incorrect encoding of AVX-512 kmovq instruction

Reviewed-by: vlivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • b040a3d: 8259631: Reapply pattern match instanceof use in HttpClientImpl
  • 3462f7a: 8256955: Move includes of events.hpp out of header files

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Jan 14, 2021
@jatin-bhateja
Copy link
Member Author

@jatin-bhateja jatin-bhateja commented Jan 14, 2021

Looks good.

Thanks Vladimir.

Loading

@jatin-bhateja
Copy link
Member Author

@jatin-bhateja jatin-bhateja commented Jan 14, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2021

@jatin-bhateja Since your change was applied there have been 3 commits pushed to the master branch:

  • b8ef2ba: 8259563: The CPU model name is printed multiple times when using -Xlog:os+cpu
  • b040a3d: 8259631: Reapply pattern match instanceof use in HttpClientImpl
  • 3462f7a: 8256955: Move includes of events.hpp out of header files

Your commit was automatically rebased without conflicts.

Pushed as commit ff3e6e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@jatin-bhateja jatin-bhateja deleted the JDK-8259773 branch Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants