Skip to content

8339366: [jittester] Make it possible to generate tests without execution#20806

Closed
lepestock wants to merge 1 commit intoopenjdk:masterfrom
lepestock:jittester/generate_test_cli/JDK-8339366
Closed

8339366: [jittester] Make it possible to generate tests without execution#20806
lepestock wants to merge 1 commit intoopenjdk:masterfrom
lepestock:jittester/generate_test_cli/JDK-8339366

Conversation

@lepestock
Copy link
Contributor

@lepestock lepestock commented Sep 2, 2024

This PR:

  1. Extracts IR tree generation from execution (left in the Automatic) into a dedicated class IRTreeGenerator;
  2. Introduces a generation result record (named IRTreeGenerator.Test). The record contains main and private classes along with the random seed used for their generation;
  3. Creates CLI-wrapper classes for Java and ByteCode generators to allow generation-only execution;
  4. Add a repeating option to the configuration - to make it possible to specify several main class names.

Sample usage:

java -cp build/classes --add-opens java.base/java.util=ALL-UNNAMED \
      jdk.test.lib.jittester.JavaCodeGenerator \
      -k Test_0 -k Test_1 -k Test_10

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339366: [jittester] Make it possible to generate tests without execution (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20806/head:pull/20806
$ git checkout pull/20806

Update a local copy of the PR:
$ git checkout pull/20806
$ git pull https://git.openjdk.org/jdk.git pull/20806/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20806

View PR using the GUI difftool:
$ git pr show -t 20806

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20806.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2024

👋 Welcome back enikitin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@lepestock This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339366: [jittester] Make it possible to generate tests without execution

Reviewed-by: lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 174 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@lepestock The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Sep 2, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2024
@lepestock
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 9, 2024
@openjdk
Copy link

openjdk bot commented Sep 9, 2024

@lepestock
Your change (at version 4d66bfd) is now ready to be sponsored by a Committer.

@lmesnik
Copy link
Member

lmesnik commented Sep 9, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 9, 2024

Going to push as commit 559fc71.
Since your change was applied there have been 174 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 9, 2024
@openjdk openjdk bot closed this Sep 9, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 9, 2024
@openjdk
Copy link

openjdk bot commented Sep 9, 2024

@lmesnik @lepestock Pushed as commit 559fc71.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants