8339313: JDK-8338888 broke 32-bit builds

[tstuefe]

See JBS issue and comment history. GCC chokes on the native test code with bogus (AFAICS) fortify errors.

In any case, since this code should not be compiled for 32-bit anyway, I exclude it. Trivial?

Tested on x86 and x64. On x86, build succeeds, on x64 we still can run runtime/exceptionMsgs/NoClassDefFoundError successfully.

Ping @dholmes-ora

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339313: JDK-8338888 broke 32-bit builds (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20809/head:pull/20809
$ git checkout pull/20809

Update a local copy of the PR:
$ git checkout pull/20809
$ git pull https://git.openjdk.org/jdk.git pull/20809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20809

View PR using the GUI difftool:
$ git pr show -t 20809

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20809.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3ddaca88)

[dholmes-ora]

In any case, since this code should not be compiled for 32-bit anyway, I exclude it. Trivial?

But as I put in JBS this is not the case, the test is not limited to 64-bit. ???

[dholmes-ora]

There is also another fix needed as the array subscripting is invalid:

diff --git a/test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/libNoClassDefFoundErrorTest.c b/test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/libNoClassDefFoundErrorTest.c
index 023f299a5d4..334974ae21d 100644
--- a/test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/libNoClassDefFoundErrorTest.c
+++ b/test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/libNoClassDefFoundErrorTest.c
@@ -51,7 +51,7 @@ static char* giant_string() {
     char* c_name = malloc(len * sizeof(char));
     if (c_name != NULL) {
         memset(c_name, 'Y', len - 1);
-        c_name[len - 1] = '\0';
+        *(c_name + len - 1) = '\0';
     }
     return c_name;
 }

[bridgekeeper]

@tstuefe This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@tstuefe This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.