Skip to content

8338891: HotSpotDiagnosticsMXBean missing @since tag #20823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Sep 2, 2024

Trivial "since" tag addition in javadoc: since 1.6


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338891: HotSpotDiagnosticsMXBean missing @since tag (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20823/head:pull/20823
$ git checkout pull/20823

Update a local copy of the PR:
$ git checkout pull/20823
$ git pull https://git.openjdk.org/jdk.git pull/20823/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20823

View PR using the GUI difftool:
$ git pr show -t 20823

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20823.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2024

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338891: HotSpotDiagnosticsMXBean missing @since tag

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0e6bb51: 8339063: [aarch64] Skip verify_sve_vector_length after native calls if SVE supports 128 bits VL only
  • b1163bc: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Sep 2, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 2, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 2, 2024

Webrevs

@kevinjwalls
Copy link
Contributor Author

Thanks Alan!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

Going to push as commit 288fa60.
Since your change was applied there have been 5 commits pushed to the master branch:

  • dc4fd89: 8339359: RISC-V: Use auipc explicitly in far_jump and far_call macro assembler routines
  • 3a88fd4: 8334724: C2: remove PhaseIdealLoop::cast_incr_before_loop()
  • 62dad3a: 8339351: Remove duplicate line in FileMapHeader::print
  • 0e6bb51: 8339063: [aarch64] Skip verify_sve_vector_length after native calls if SVE supports 128 bits VL only
  • b1163bc: 8256211: assert fired in java/net/httpclient/DependentPromiseActionsTest (infrequent)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 3, 2024
@openjdk openjdk bot closed this Sep 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2024
@openjdk
Copy link

openjdk bot commented Sep 3, 2024

@kevinjwalls Pushed as commit 288fa60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@@ -47,6 +47,8 @@
* {@code null} unless it's stated otherwise.
*
* @see java.lang.management.ManagementFactory#getPlatformMXBeans(Class)
*
* @since 1.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the copyright for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants