8339399: ZGC: Remove unnecessary page reset when splitting pages

[jsikstro]

There is no use-case where it is necessary to reset the same page after splitting and thus the reset should be removed.

Tested with tiers 1-3.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8339399: ZGC: Remove unnecessary page reset when splitting pages (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Erik Österlund (@fisk - Reviewer)
• Axel Boldt-Christmas (@xmas92 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20824/head:pull/20824
$ git checkout pull/20824

Update a local copy of the PR:
$ git checkout pull/20824
$ git pull https://git.openjdk.org/jdk.git pull/20824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20824

View PR using the GUI difftool:
$ git pr show -t 20824

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20824.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339399: ZGC: Remove unnecessary page reset when splitting pages

Reviewed-by: stefank, eosterlund, aboldtch

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• f2c992c: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
• 9a1024d: 8190329: [macos] Swing InterOp Platform.exit() crash
• 5998f4b: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can be removed
• 90f3f43: 8328877: [JNI] The JNI Specification needs to address the limitations of integer UTF-8 String lengths
• bbb5161: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
• a22e932: 8337163: Improve SA error message when failing to attach to a core file
• a7120e2: 8311993: Test serviceability/sa/UniqueVtableTest.java failed: duplicate vtables detected
• 5ebdf2d: 8338708: Don't create/destroy debug agent cmdQueueLock for each connection
• 130ac13: 8337265: Test static-libs build in GitHub Actions
• cfec3ac: 8337317: serviceability/jvmti tests failed with FATAL ERROR in native method: Failed during the GetClassSignature call
• ... and 18 more: https://git.openjdk.org/jdk/compare/03ba37e60ce08def6afd172efc1cdbbcc856c633...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@stefank, @fisk, @xmas92) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@jsikstro The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (b6fee027)

[stefank]

Looks good.

[fisk]

Looks good.

[xmas92]

lgtm.

[jsikstro]

Thank you for the reviews! @stefank @fisk @xmas92
/integrate

[openjdk]

@jsikstro
Your change (at version b6fee02) is now ready to be sponsored by a Committer.

[stefank]

/sponsor

[openjdk]

Going to push as commit a618605.
Since your change was applied there have been 28 commits pushed to the master branch:

• f2c992c: 8339300: CollectorPolicy.young_scaled_initial_ergo_vm gtest fails on ppc64 based platforms
• 9a1024d: 8190329: [macos] Swing InterOp Platform.exit() crash
• 5998f4b: 8308588: Unnecessary synchronized on GTKStyle#ICONS_MAP can be removed
• 90f3f43: 8328877: [JNI] The JNI Specification needs to address the limitations of integer UTF-8 String lengths
• bbb5161: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
• a22e932: 8337163: Improve SA error message when failing to attach to a core file
• a7120e2: 8311993: Test serviceability/sa/UniqueVtableTest.java failed: duplicate vtables detected
• 5ebdf2d: 8338708: Don't create/destroy debug agent cmdQueueLock for each connection
• 130ac13: 8337265: Test static-libs build in GitHub Actions
• cfec3ac: 8337317: serviceability/jvmti tests failed with FATAL ERROR in native method: Failed during the GetClassSignature call
• ... and 18 more: https://git.openjdk.org/jdk/compare/03ba37e60ce08def6afd172efc1cdbbcc856c633...master

Your commit was automatically rebased without conflicts.

[openjdk]

@stefank @jsikstro Pushed as commit a618605.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.